[$250] Unread chats are not shown bold but shown as unread when search

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710873829984469

Action Performed:

1. Go to staging.new.expensify.com and sign in
2. Click on search icon
3. See there is an unread message in #social public room
4. Go to LHN

Expected Result:

#social public room should have unread indicator

Actual Result:

It does not show as unread
LHN is correct as there are many unread messages in the chat page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0177e0a39535aa44ec
• Upwork Job ID: 1783231919721689088
• Last Price Increase: 2024-05-08

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

@dylanexpensify I'm heading out until the 2nd. Can I hand you this over to progress? I was wondering if it's related to #36075. Said differently, I don't know how this bug wasn't caught in the development of the fix for the other one really.

[dylanexpensify]

@trjExpensify you got it! Will look into this today! Feel free to assign over!

[trjExpensify]

Ta!

[dylanexpensify]

waiting for someone to ping in social lol

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

reviewing today!

[dylanexpensify]

Having a hard time reproducing to be honest. Logging in takes me automatically to social. And I'm seeing LHN act according as it should.

[dylanexpensify]

@m-natarajan can you still repro?

[iwiznia]

I can

Maybe because of this?

[dylanexpensify]

Ahhh nice shout @iwiznia! I'll give it a try with that.

[puneetlath]

I also reported similar here: https://expensify.slack.com/archives/C049HHMV9SM/p1713218931132899

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[fitd-tech]

Hello Expensify team! I'd like to make a proposal for this (my first!), but I'm trying to understand the issue fully.

Please re-state the problem that we are trying to solve in this issue.
It seems that when there is unread activity in a muted channel, it is not bold in the LHN. However, if you go to Search and find the same channel, it will be bold to indicate the activity.

What is the root cause of that problem?
If my understanding is correct, my proposal involves altering the variable definition for textUnreadStyle in the OptionRowLHN component. This definition contains a condition that doesn't apply the unread text style if the user has muted notifications. I'm not sure why this was done, since muting notifications doesn't seem to mean the user shouldn't see the bold text indication (only that they don't get notifications for it).

What changes do you think we should make in order to solve the problem?
I would like to remove the condition to check for muted notifications from this definition, as long as it is indeed incorrectly placed.

What alternative solutions did you explore? (Optional)
I looked into the the reason the search results are in bold, and it seems to support my proposal. The report is generated to assign any occurrence of isUnread to isBold and InviteMemberListItem looks for isBold alone to assign the respective styles. There is no check for muted notifications here.

Thanks for your consideration!

(edited to use the proposal template provided)

[melvin-bot]

📣 @fitd-tech! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[fitd-tech]

Contributor details
Your Expensify account email: tony@fitd.tech
Upwork Profile Link: https://www.upwork.com/freelancers/~0112f1c05cee2d1939

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Ollyws]

So it seems to me that the problem here is that we intentionally don't bold new messages if the notifications are muted (#33779) but we only do this for OptionRowLHN resulting in an inconsistency between the LHN and the seach list.

@fitd-tech Thanks for the proposal, it's going in the right direction but I think we want to preserve the current behaviour for the LHN.

[fitd-tech]

Thanks @Ollyws! Let me know if I can do anything further.

[Ollyws]

Feel free to update your proposal so that neither the LHN or search list are bolded when notifications are muted.

[fitd-tech]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The search list shows items with new activity in bold, even if they have been muted. The LHN does not show this activity, and we would like them to be consistent, so we should remove the bold styling from the search results when notifications are muted. (This description is the inverse of the original bug report, but seems more in line with our intent)

What is the root cause of that problem?

In the OptionRowLHN component, we check the user notification settings to determine whether we will apply bold styles to the list items:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 59 in db9be2c

const textUnreadStyle = optionItem?.isUnread && optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];

In the ChatFinderPage component of the search function, we set a flag for isBold on each result without checking the user settings first:

App/src/pages/ChatFinderPage/index.tsx

Lines 119 to 124 in db9be2c

	if (recentReports?.length > 0) {
	newSections.push({
	data: recentReports.map((report) => ({...report, isBold: report.isUnread})),
	shouldShow: true,
	});
	}

What changes do you think we should make in order to solve the problem?

I would like to add the same settings condition to the ChatFinderPage component sections list, so the InviteMemberListItem component only applies bold styling if the user hasn't muted notifications.

What alternative solutions did you explore? (Optional)

I could add this check to the InviteMemberListItem component instead:

App/src/components/SelectionList/InviteMemberListItem.tsx

Lines 97 to 107 in a310f77

	<TextWithTooltip
	shouldShowTooltip={showTooltip}
	text={Str.removeSMSDomain(item.text ?? '')}
	style={[
	styles.optionDisplayName,
	isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText,
	item.isBold !== false && styles.sidebarLinkTextBold,
	styles.pre,
	item.alternateText ? styles.mb1 : null,
	]}
	/>

...but since semantically we are setting isBold, I would prefer that is only true if the item will actually be rendered in bold.

[dylanexpensify]

@Ollyws can we get an update on the updated proposal? 🙇‍♂️

[Ollyws]

@fitd-tech's proposal LGTM, but we should get clarificaion from the internal engineer that this is absolutely the desired behaviour because as @fitd-tech mentioned it is kind of the inverse of the actual bug report.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dylanexpensify]

Bump @tylerkaraszewski to review

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@tylerkaraszewski, @Ollyws, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@Ollyws can you repro? I can't

[Ollyws]

@dylanexpensify I can still reproduce, the issue is that when we set the notification preference to mute the chat is still bolded in the search but not in the LHN.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[melvin-bot]

@tylerkaraszewski, @Ollyws, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...