Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Taxes - Cursor is placed before the value when reopening saved value #39081

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 27, 2024 · 64 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #38733

Action Performed:

Precondition:

  • User is admin of Collect workspace
  1. Go to staging.new.expensify.com
  2. Go to Profile > Workspaces > Collect workspace
  3. Go to Taxes > Add rate > Value
  4. Enter any value and save it
  5. Tap Value again

Expected Result:

Cursor is placed behind the value

Actual Result:

Cursor is placed in front of the value. Sometimes it appears behind the value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428815_1711552320921.Screen_Recording_20240327_230730_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01515a93e0ea4bae26
  • Upwork Job ID: 1774175994999578624
  • Last Price Increase: 2024-05-07
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-control

@Krishna2323

This comment was marked as outdated.

@MitchExpensify MitchExpensify added the External Added to denote the issue can be worked on by a contributor label Mar 30, 2024
Copy link

melvin-bot bot commented Mar 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01515a93e0ea4bae26

@melvin-bot melvin-bot bot changed the title Android - Taxes - Cursor is placed before the value when reopening saved value [$500] Android - Taxes - Cursor is placed before the value when reopening saved value Mar 30, 2024
@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Mar 30, 2024
Copy link

melvin-bot bot commented Mar 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@Krishna2323
Copy link
Contributor

Proposal Updated

  • Added optional

@abzokhattab
Copy link
Contributor

Not reproducible on main in my case:

Screen.Recording.2024-03-31.at.12.54.40.AM.mov

@Krishna2323
Copy link
Contributor

Proposal Updated

  • Update optional

@Krishna2323
Copy link
Contributor

Proposal Updated

  • Updated optional

@MitchExpensify
Copy link
Contributor

Proposals ready for you @cubuspl42

@cubuspl42
Copy link
Contributor

Sorry if this is obvious, but how can I enter the "Taxes" screen?

This is a Collect workspace, I'm the admin.

image

@kmbcook
Copy link
Contributor

kmbcook commented Apr 2, 2024

@cubuspl42 below Profile and Members you should also see More Features. Enable Taxes under More Features. My collect workspace was created on old dot. I don't know if that makes a difference.

@cubuspl42

This comment was marked as outdated.

@Krishna2323
Copy link
Contributor

@cubuspl42, I guess you are not the admin of the workspace.

@cubuspl42
Copy link
Contributor

I thought "owner" and "admin" are the same. You can see that I'm the owner on the screenshots.

@Krishna2323
Copy link
Contributor

It should have all these options.
image

@cubuspl42
Copy link
Contributor

I found a solution; see this Slack message. I'll see if I can reproduce this issue now.

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@cubuspl42
Copy link
Contributor

@lanitochka17 @MitchExpensify I can't reproduce, same as in this comment.. I tested on latest main.

@hoangzinh
Copy link
Contributor

@Krishna2323 Just wanna confirm, are you going to update your proposal again with this comment #39081 (comment)? Btw, could you confirm if you can still reproduce this bug in the latest main branch? Thanks a lot.

@Krishna2323
Copy link
Contributor

@hoangzinh, I wasn't able to reproduce this issue in other amount forms but this is still reproducible on Tax amount page. I don't think we want to make the changes in TextInput component.

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@MitchExpensify
Copy link
Contributor

Not overdue, actively being worked on and the ball is in @hoangzinh 's court to consider @Krishna2323 's response above

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@MitchExpensify
Copy link
Contributor

Friendly bump @hoangzinh

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@hoangzinh
Copy link
Contributor

The onSelectionChange runs on initial render and returns e.nativeEvent.selection as {"end": 0, "start": 0} sometimes

@Krishna2323 can you find any upstream issue link mentioned to this bug?

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@MitchExpensify
Copy link
Contributor

Friendly bump @Krishna2323

@melvin-bot melvin-bot bot removed the Overdue label May 5, 2024
@Krishna2323
Copy link
Contributor

@hoangzinh, I couldn't find any upstream issue link.

Copy link

melvin-bot bot commented May 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label May 7, 2024
@hoangzinh
Copy link
Contributor

@lanitochka17 sorry for asking again, can you still reproduce this bug?

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@lanitochka17
Copy link
Author

Issue is still reproducible

Screen_Recording_20240509_203927_New.Expensify.mp4

@hoangzinh
Copy link
Contributor

@MitchExpensify I'm unable to reproduce this bug on my end. To speed up the progress of this issue, Can I ask in C+ group if anyone can reproduce then they can pick up this issue, what do you think?

@MitchExpensify
Copy link
Contributor

@mananjadhav
Copy link
Collaborator

I couldn't reproduce it at my end on physical Android device, prod 1.4.71-6. @lanitochka17 Could you share some details on your device and the app version?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 12, 2024
@mananjadhav
Copy link
Collaborator

Was able to reproduce this on my Android emulator. @MitchExpensify Can you add the Help Wanted label.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mananjadhav
Copy link
Collaborator

@mvtglobally I am able to reproduce it on my emulator.

Screen.Recording.2024-05-14.at.1.07.11.AM.mov

@MitchExpensify
Copy link
Contributor

Given this is such minor issue, isolated to Android, and we're having trouble replicating it I don't think this is worth our time

@Krishna2323
Copy link
Contributor

@MitchExpensify, what do you think about the other bug, the amount input is not cleared when we go back without saving it. I can still reproduce the cursor bug easily on my physical device and emulator.

edited_amount_not_cleared_tax_page.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Archived in project
Development

No branches or pull requests

10 participants