[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$500] [TS Migration] Adjust eslint config, TS config

[mountiny]

Follow up issue for TS migration project. Coming from this spreadsheet

Błażej: Remove JS specific rules, merge some of them, disallow JS in TS Config, needs investigation

Also adjust https://typescript-eslint.io/rules/no-unused-vars/ Eslint rule to allow unused arguments starting with underscore

cc @blazejkustra @fabioh8010

Issue Owner

Current Issue Owner: @trjExpensify / @bfitzexpensify

Issue Owner

Current Issue Owner: @trjExpensify / @bfitzexpensify

Issue Owner

Current Issue Owner: @trjExpensify / @bfitzexpensify

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[blazejkustra]

Update: I was sick last week, I'm aiming to have a PR ready for review tomorrow.

[blazejkustra]

Draft PR is up! cc @fabioh8010

[war-in]

We've decided to remove eslint rules in separate PR because of a huge amount of TS errors (check @blazejkustra's comment). I'll take care of it

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[parasharrajat]

I was C+ on the PR.

[bgawkuc]

Hi, as @blazejkustra and @war-in mentioned we'd like to split it into smaller PRs. I'd like to work on enabling no-unsafe-call eslint rule

[mountiny]

Thanks, please go ahead

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enable no-unsafe-member-access eslint rule #43557

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @blazejkustra does not require payment (Contractor)
• @war-in does not require payment (Contractor)
• @bgawkuc does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[parasharrajat]

There is one more PR.

[mountiny]

Merged

[parasharrajat]

There were 3 PRs to review. Can we reconsider the C+ compensation for this issue? @trjExpensify

[mountiny]

Yes I think $500 is deserved compensation for this issue

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[trjExpensify]

Cool, put $500 in the title to not forget. Payout due on the 10th.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Enable no-unsafe-assignment eslint rule #44003

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @blazejkustra does not require payment (Contractor)
• @war-in does not require payment (Contractor)
• @bgawkuc does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[trjExpensify]

I think this one is due.

Payment summary as follows:

• $500 to @parasharrajat for the review.

Closing!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Enable no-unsafe-assignment eslint rule #44003

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @blazejkustra does not require payment (Contractor)
• @war-in does not require payment (Contractor)
• @bgawkuc does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[parasharrajat]

Payment requested as per #39119 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat