Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] BNP - Inconsistency in pointer position on android native and mWeb #39611

Closed
3 of 6 tasks
kbecciv opened this issue Apr 4, 2024 · 9 comments
Closed
3 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team

Action Performed:

  1. Click on 'FAB'
  2. Click on 'Request money'

Expected Result:

Pointer position should be consistent across platform. Pointer at end would good to clear zeros first before putting number.

Actual Result:

Android pointer position is start and mWeb and Web pointer position is at end

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

Bug6437968_1712235779049.Screen_Recording_20240404_160203_New_Expensify.mp4
Bug6437968_1712235676113.Screen_Recording_2024-04-04_at_4.00.43_in_the_afternoon.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2024

I believe this revert will fix it too #39610

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 4, 2024

@Expensify/applause Can we retest this since a fix was CP'd to staging in #39610?

@kavimuru
Copy link

kavimuru commented Apr 5, 2024

@mountiny issue is fixed now.

Screen_Recording_20240405_162106_Chrome.mp4
Screen_Recording_20240405_162005_New.Expensify.mp4

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

Thanks!

@mountiny mountiny closed this as completed Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title BNP - Inconsistency in pointer position on android native and mWeb [HOLD for payment 2024-04-15] BNP - Inconsistency in pointer position on android native and mWeb Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants