Deploy Checklist: New Expensify 2024-04-04

[github-actions]

Release Version: 1.4.60-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [CP Stag] Fix pasting text into main composer #39177
• [No QA][TS migration] Migrate 'reviewerChecklist.js', 'getReleaseBody.js', 'getPreviousVersion.js' and 'checkDeployBlockers.js' .github files to Typescript #39197
• Fix going back from wallet page returns to the same page after adding a bank account #39351
• [CP Stag] Fix inline code font size in composer #39516
• [NoQA] Delete docs/articles/expensify-classic/copilots-and-delegates/User-Ro… #39528
• Update redirects.csv #39530
• [CP Staging] Fix three-dot menu item display incorrectly when opening receipt in combine report #39572
• Attempt to fix deploy script #39580
• [NO QA] Fix GitHub action commenting #39593
• Revert "35797-preserving-the-transactions-amounts-the-same-as-entered" #39610
• [CP Stag][Fix] One character jumps "after" cursor when typing fast #39621
• Bump expensify-common #37723 #39634
• [CP Staging] Fix crash with zero tax rate and allow tax amount to be zero #39638
• [CP Staging] fix: taxpicker selection for tax settings #39646
• [CP Staging] Revert "Defer local updates if there are missing updates and only call GetMissingOnyxMessages once" #39668
• [CP Staging] Fix crash when tax rate is deleted #39707
• [CP Staging] Validate tax amount in edit flow and fix skeleton #39720
• [CP Staging] Fix report and personal detail options are persisted after switching account #39753

Deploy Blockers:

• [HOLD for Payment 2024-05-29] [$250] Web - Attachment - The action bar flickers when downloading a video. #39598
• [HOLD for payment 2024-04-15] BNP - Unable to enter number on BNP unless the number 0.00 is erased first #39599
• [$500] Taxes - App crashes when changing tax rate to 0% on native apps and it shows 00 on web #39600
• Taxes - Tax amount input in transaction thread is not auto-focused #39601
• Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate #39602
• [$250] Chat - The written message does not appear in the composer after navigating via a deep link to the last message. #39603
• Taxes - System message for tax amount edit shows USD first, then changes to correct currency #39605
• [HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section #39607
• mWeb - Chat - When opening a request and going back, the requests list is displayed empty #39609
• [HOLD for payment 2024-04-15] BNP - Inconsistency in pointer position on android native and mWeb #39611
• [HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation #39613
• Taxes - Tax rate and tax amount take some time to show up in transaction thread #39615
• [Awaiting Payment 22nd May] [$250] [Track Tax] - Support for tax tracking when offline #39616
• Chat - Second and subsequent messages not displayed in chat until chat reloaded #39650
• [HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report #39679
• [HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline #39689
• [$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Track Tax] Support tax tracking for split requests with workspace #39690
• [HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error #39691
• [PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session #39695
• [Pay 4/29][$250] [Track Tax] Error on Amount and Merchant field after changing tax rate when scanning is ongoing #39699
• [HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time #39701
• [Track Tax] Expense request with tax amount higher than the tax rate limit can be created #39703
• Search - Created task not displayed in search results until page refreshed #39705
• [HOLD FOR SEARCH] IOU Actions - Notifications don't come if subscribed from combined report #39706
• [HOLD for payment 2024-04-15] [$500] Start chat - App shows data from User A after logging out of User A and logging in with User B #39710
• IOU - User able to start Money Request flow on IOU details page #39763
• Tax and tax amount are updated little bit delayed in transaction thread page. #39804

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mountiny]

@Expensify/applauseleads Please use the below checklist + the one above as we cannot update the OP easily - each CP would overwrite it:

• feat: add edit fields for tax tracking #33927
• HIGH: Kill ReconnectToReport #34902
• Corrected Currency Display: Enforce Two Decimal Places in Amounts #35797
• Fix/address page state navigation 2 #36770
• [TS migration] Migrate 'sanitizeStringForJSONParse.js', 'promiseWhile.js', 'CONST.js', 'versionUpdater.js', 'ActionUtils.js' .github file to TypeScript  #37975
• perf: Cache search options #38207
• Issue/36520 android scan second tap on capture button causes error to show up #38320
• Fix video replay issue in iOS #38419
• Refactored selection list items #38448
• Fix: Read API is not triggered consistently when switching between features of a Collect workspace #38613
• [No QA][TS migration][g21] Migrate multiple Github utils #38800
• feat: access client side logging from Test Tools Modal #38803
• Fix for "No results found" text is not aligned to left edge #38852
• Fix - Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38882
• Fix/38814: Distance - Unable to save second distance edit offline #38987
• [TS migration] Migrate withFullTransactionOrNotFound HOC to TypeScript #38990
• Validate different phone number formats #38993
• [TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995
• Defer local updates if there are missing updates and only call GetMissingOnyxMessages once #38997
• Replaces usage of reimburserEmail with achAccount.reimburser #39017
• fix: categorize all expense switch is not disabled #39036
• [NoQA] fix: real startup metric #39070
• 38229 hide approve on submit and close #39071
• Update redirects.csv #39089
• Linking without loader #39166
• [No QA][TS migration] Migrate 'reviewerChecklist.js', 'getReleaseBody.js', 'getPreviousVersion.js' and 'checkDeployBlockers.js' .github files to Typescript #39197
• [NoQA] feat: more startup marks #39181
• Change the order of items in global create menu #39204
• Fix: Indented text does not show in quotes #39207
• Group chat: Use draft only on init and on draft changes #39312
• Fix skeleton display on send money request flow #39326
• fix: Start chat - Chat RHP switches to Room tab when dragging input from right to left #39329
• Remove deprecated ReportUtils.getPolicy() method #39344
• fix message highlight color #39346
• Fix going back from wallet page returns to the same page after adding a bank account #39351
• FIx group chat confirmation list is displayed with delay #39364
• [NoQA] Update CODEOWNERS to support Design team handle for src/styles/ directory #39365
• Remove comment linking beta flag #39371
• fix: mWeb - Task - Assigned to email id is cut off in task details page. #39401
• Fix cannot clear error of modified action in one transaction report #39474
• Fixing the navigation of leaving self-dm thread #39476
• Fix user can save address without zip code even when the country requires zip code #39486
• Revert "[TS migration] Migrate withFullTransactionOrNotFound HOC to TypeScript" #39539
• Attempt to fix deploy script #39580

[rlinoz]

Demoting #39601

[mountiny]

Demoted #39598

[amyevans]

Demoted #39603

[jasperhuangg]

Checking off #39605 NAB

[jasperhuangg]

Checking off #39607 NAB

[jasperhuangg]

Checking off #39615 NAB

[jasperhuangg]

Checking off #39609 Back-end issue

[jasperhuangg]

Checking off #39650 back-end issue

[jasperhuangg]

Checking off #39600 fixed in CP

[kavimuru]

Regression is 87% progress.
#34902 failing with #39650
#39036 failing with #37508 and bug is not fixed in all the platforms, please see the commet
#39351 failing with #38558 and bug is not fixed in Web, please see the comment

#33927 pending validation in desktop and iOS
#38207 pending validation in iOS
#38613 pending validation in mweb and android
#38993 pending validation in mweb
#39017 pending validation in mweb, desktop and iOS
#39071 pending validation in iOS

[aldo-expensify]

Checked #39650 off

[mountiny]

Checked off:

• HIGH: Kill ReconnectToReport #34902 the identified issue was resolved
• fix: categorize all expense switch is not disabled #39036 as the failing QA was noted
• Fix going back from wallet page returns to the same page after adding a bank account #39351 as the failing QA was noted

[mountiny]

Demoted #39689

[kavimuru]

Regression is completed.

Unchecked PRs
#38997- We are unsure of the step 3 asked help here. Also it seems this PR is reverted.
#33927 failing with #39600 and #39616

We are working on the CPs

[mountiny]

Checking #33927 off, we will control the deploy blockers/ CPs

[mountiny]

Checking #38997 it was reverted

[mountiny]

demoted #39705

[mountiny]

Demoting #39703 cc @MonilBhavsar

[luacmartins]

Checking off #39763. Expected behavior

[Julesssss]

Most of the remaining are CPs. I'll be reaching out to those to confirm these were tested manually.

[Julesssss]

• [CP Stag] Fix pasting text into main composer #39177 tested here
• [CP Stag] Fix inline code font size in composer #39516 tested here
• [CP Staging] Fix crash with zero tax rate and allow tax amount to be zero #39638 tested here

[Julesssss]

• [CP Staging] fix: taxpicker selection for tax settings #39646 tested here
• [CP Staging] Fix crash when tax rate is deleted #39707 tested here

[Julesssss]

Checked off #39804 as not-a-blocker.

[Julesssss]

Checked off
#39646 verified here
#39720 verified here
#39753 verified by QA here
#39572 tested here

[Julesssss]

• Github status ✅
• App Timing Dash ✅
  • Regression in timing, but this occurred a week ago, not with these changes
  • Mostly occurring on Desktop
• Firebase ✅
  • Android: No new crashes, 3 occurrences of a widely occurring existing issue
  • iOS: No new crashes

[Julesssss]