Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - User able to start Money Request flow on IOU details page #39763

Closed
6 tasks done
lanitochka17 opened this issue Apr 5, 2024 · 5 comments
Closed
6 tasks done

IOU - User able to start Money Request flow on IOU details page #39763

lanitochka17 opened this issue Apr 5, 2024 · 5 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-12
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: user should be singed in

  1. Open app
  2. Open any chat with another user where there has been no money request in the past
  3. Make a Money Request
  4. Tap on the IOU preview
  5. Tap on Plus button next to composer
  6. Select "Request Money"
  7. Write any amount and tap on continue
  8. Navigate back to 1:1 DM chat with user
  9. Tap on IOU preview
  10. Make a Money Request
  11. Tap on iOU preview
  12. Tap on Plus button next to composer

Expected Result:

User should not be ablte to start the Money Request flow from the IOU details page

Actual Result:

User able to start Money Request flow on IOU details page when first IOU was made. When user made the second IOU, the Money Request option is no more available on IOU details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6439603_1712348169679.RPReplay_Final1712348043.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@paultsimura
Copy link
Contributor

This looks like an expected behavior: here the combined (1-transaction IOU Report view) is just mistaken for the IOU Details page.
The user should be able to request money from the 1-transaction IOU Report to turn it into a regular IOU Report view.

@luacmartins
Copy link
Contributor

Agreed! We changed the layout of the chat reports, so this is expected now. Closing. @lanitochka17 please note that the new Expense report layout is now the same as the Expense thread if the Expense report has only one expense.

@luacmartins luacmartins removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants