Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Created task not displayed in search results until page refreshed #39705

Closed
2 of 6 tasks
kbecciv opened this issue Apr 5, 2024 · 20 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4478317
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and log in
  2. Open any chat
  3. Create a task with a unique name
  4. Click on the search icon
  5. Search for the task

Expected Result:

The task is displayed in the search results

Actual Result:

The task is not displayed in the search results until the page is refreshed

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438806_1712295173562.Recording__379.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Apr 5, 2024

We think that this bug might be related to #vip-vsb

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

I dont think this has to be a blocker as its a quite specific flow

I believe its coming from #38207 cc @TMisiukiewicz can you have a look please

@TMisiukiewicz
Copy link
Contributor

@mountiny yes please assign me 🙏

@mountiny mountiny assigned TMisiukiewicz and mountiny and unassigned johnmlee101 Apr 5, 2024
@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

I can take over here @johnmlee101 if you dont mind

Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 5, 2024
@TMisiukiewicz
Copy link
Contributor

I already found what is causing the issue - the cached list is updated when a single reports updates, but it does not have a mechanism of creating a new option when a new item is created. I need some more time to figure out how to implement it and not downgrade the performance, going to continue working on that Monday morning

@TMisiukiewicz
Copy link
Contributor

Opened a draft PR, however reassure test was failing - I'm looking into that before opening

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Apr 8, 2024
@TMisiukiewicz
Copy link
Contributor

Found one more related issue when requesting/sending money from non-existing account, gonna fix it with the same PR

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2024
@TMisiukiewicz
Copy link
Contributor

@mountiny I just opened the PR - the issue I had with non-existing account seem to not be related to my recent changes. I was trying to figure out if invited accounts are displayed on the search (the answer is yes), but I have encountered a weird behavior. After requesting money from non-existing account, the report opens with an e-mail address visible. After getting a response from API it changes to "Hidden". After refreshing the app, the email is visible again. I tried to track which change caused it, and noticed on version 1.4.60 it still works fine, but it happens on 1.4.61. Is this a known issue?

@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

. I tried to track which change caused it, and noticed on version 1.4.60 it still works fine, but it happens on 1.4.61. Is this a known issue?

I am not aware of this issue, could you report it in the open source channel please 🙏

@TMisiukiewicz
Copy link
Contributor

@mountiny posted here

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

This issue has not been updated in over 15 days. @JmillsExpensify, @TMisiukiewicz, @mountiny, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@JmillsExpensify
Copy link

What's the latest on this issue?

@TMisiukiewicz
Copy link
Contributor

@JmillsExpensify it was fixed in #39811

@JmillsExpensify
Copy link

Ah perfect. So all that is left is a payment summary: $250 to @thesahindia for PR review and testing. I'm closing this issue as C+ is paid out via New Expensify. @thesahindia make sure to comment on whether a regression test is needed when you request payment. Thanks!

@thesahindia
Copy link
Member

I think it's quite specific, so I don't think we need a test case.

@laurenreidexpensify
Copy link
Contributor

Payment Summary

C+ @thesahindia $250 please request in newdot
Contributor @TMisiukiewicz agency worker, no payment required

@JmillsExpensify
Copy link

$250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants