[Awaiting Payment][$250] PDF - "Send" button is missing on password protected PDF preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481584
Email or phone of affected tester (no customers): vdargentotest+mweb040824@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: the user must be logged in

1. Go to any chat
2. Try to send a password protected PDF (there is one attached to this report, password: "Test12345")
3. On the preview before sending, tap on "enter the password"
4. Enter the password and tap on "Confirm"
5. Verify the PDF is displayed but there is no "Send" button at the bottom

Expected Result:

"Send" button should be displayed below de PDF

Actual Result:

The "Send" button is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442587_1712597008201.Hbnm6617_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01addbe94fe205e652
• Upwork Job ID: 1777461049030750208
• Last Price Increase: 2024-04-08
• Automatic offers:
• dukenv0307 | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[thienlnam]

Looks like the keyboard is coming up and covering the send button - this looks like it could be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01addbe94fe205e652

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[thienlnam]

I don't think this needs to be a blocker though, seems like they could just close the keyboard if needed, and is not a common flow

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Send" button is missing

What is the root cause of that problem?

We pass isKeyboardOpen state into onToggleKeyboard function which is not updated at the time we call onToggleKeyboard function. At the time we call onToggleKeyboard when the keyboard is closed, isKeyboardOpen is still true and then the send button is hidden by the logic here

App/src/components/PDFView/index.tsx

Lines 30 to 40 in 38ced97

	* On small screens notify parent that the keyboard has opened or closed.
	*
	* @param isKeyboardOpen True if keyboard is open
	*/
	const toggleKeyboardOnSmallScreens = useCallback(
	(isKBOpen: boolean) => {
	if (!isSmallScreenWidth) {
	return;
	}
	setIsKeyboardOpen(isKBOpen);
	onToggleKeyboard?.(isKeyboardOpen);

What changes do you think we should make in order to solve the problem?

We should pass isKBOpen into onToggleKeyboard function instead of passing isKeyboardOpen

App/src/components/PDFView/index.tsx

Lines 30 to 40 in 38ced97

	* On small screens notify parent that the keyboard has opened or closed.
	*
	* @param isKeyboardOpen True if keyboard is open
	*/
	const toggleKeyboardOnSmallScreens = useCallback(
	(isKBOpen: boolean) => {
	if (!isSmallScreenWidth) {
	return;
	}
	setIsKeyboardOpen(isKBOpen);
	onToggleKeyboard?.(isKeyboardOpen);

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

@nkdengineer's proposal looks good to me. We should update the parameter name here too

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @strepanier03, @thienlnam, @dukenv0307, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[thienlnam]

Seems the automation didn't work here, but this is ready for payment cc @strepanier03

[strepanier03]

Thanks @thienlnam I appreciate you changing the priority for this 🙌

[strepanier03]

@dukenv0307 - Paid via Upwork.
@nkdengineer - Offer sent via Upwork. Will check this Monday.

[nkdengineer]

@strepanier03 I accepted the offer 🙏

[strepanier03]

Thanks @nkdengineer - Paid and contract closed 🎉