[HOLD for payment 2024-07-17][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #38674
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Go offline.
4. Type @ and search for user that shows the fallback avatar in offline mode.
5. Use keyboard key to highlight the selection.

Expected Result:

The background of the fallback avatar should be visible when the user with fallback avatar is highlighted in the suggestion list.

Actual Result:

The background of the fallback avatar has the color as the selection highlight, so the background appears invisible when it is highlighted. This issue occurs in both light and dark mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6443096_1712637992454.20240409_123616.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d901ad4a12b6e9e
• Upwork Job ID: 1777661865535434752
• Last Price Increase: 2024-04-09
• Automatic offers:
• tienifr | Contributor | 0
• eh2077 | Contributor | 102899881

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Recording.2359.mp4

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The background of the fallback avatar has the color as the selection highlight, so the background appears invisible when it is highlighted. This issue occurs in both light and dark mode.

What is the root cause of that problem?

Fallback icon is updated in this PR to support theme. That cause this issue

What changes do you think we should make in order to solve the problem?

This issue is not happen in other list like search page, so we should do the same for more consistency

Update background color of focused suggestion here like what we did with sidebar link here

What alternative solutions did you explore? (Optional)

NA

Result

[Beamanator]

cc @grgia - since you're the author of #38674 - do you agree with the proposal above to fix this deploy blocker? Do you want to take over this issue? Looks like a quick fix

[grgia]

Yeah! Exactly what I was going to suggest. All yours @tienifr, but removing the blocker label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d901ad4a12b6e9e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[abekkala]

@rushatgabhane assigned you as I see you did the PR review yestereday

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Fallback avatar background and selection highlight have the same color #43077

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR JULY 17

• Fix: @tienifr [$250, if no regressions] payment via NewDot
• PR Review: @rushatgabhane [$250, if no regressions] payment via NewDot

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Fallback avatar background and selection highlight have the same color #43077

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[abekkala]

PAYMENT SUMMARY FOR JULY 17

• Fix: @tienifr [$250, if no regressions] payment via NewDot
• PR Review: @rushatgabhane [$250, if no regressions] payment via NewDot

[abekkala]

This was not a regression - ready for payment!

[abekkala]

PAYMENT SUMMARY FOR JULY 17

• Fix: @tienifr [$250] payment via NewDot
• PR Review: @rushatgabhane [$250] payment via NewDot

[JmillsExpensify]

$250 approved for @rushatgabhane

[JmillsExpensify]

$250 approved for @tienifr