[HOLD for payment 2024-08-29] [$125] Start chat - Add to group button has same color as background

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Search for a user.

Expected Result:

Add to group button will have distinctive color than the background when highlighted and not hovered.

Actual Result:

Add to group button has the same color as the background when highlighted and not hovered.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532497_1720042215539.add_group.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01252a470389048ef6
• Upwork Job ID: 1809050228518754499
• Last Price Increase: 2024-07-05
• Automatic offers:
• c3024 | Reviewer | 103042565

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[gijoe0295]

Regression from #43077:

App/src/styles/index.ts

Line 1808 in 8511f5f

backgroundColor: theme.activeComponentBG,

[Sparth19]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Start chat --> add to group button has same color as background color when highlighted not hovered

What is the root cause of that problem?

• The given style for the highlighted (focused) state has a different color than required.

What changes do you think we should make in order to solve the problem?

• We need to change the background color in the highlight state (i.e isFocused )
  

  App/src/components/SelectionList/UserListItem.tsx

  Line 54 in 83eb7e6

  wrapperStyle={[styles.flex1, styles.justifyContentBetween, styles.sidebarLinkInner, styles.userSelectNone, styles.peopleRow, isFocused && styles.sidebarLinkActive]}

wrapperStyle={[
              //other styles
               isFocused && [styles.sidebarLink, styles.buttonHoveredBG],
           ]}

• With these changes, it will show the background color as specified in ND

Result

Screen.Recording.2024-07-04.at.10.40.52.AM.mov

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01252a470389048ef6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Upwork job price has been updated to $125

[dukenv0307]

proposal from @dominictb LGTM

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[dukenv0307]

@grgia What do you think about my decision above? Thanks

[grgia]

yep, assigning!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Add to group button has same color as background #47516

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment (Needs manual offer from BZ)
• @dominictb requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

issued @dukenv0307 an offer, and pinged @dominictb for their profile

[dominictb]

@miljakljajic I've replied with the profile link via Slack DM 👍

[miljakljajic]

@dominictb has been paid - @dukenv0307 give me heads up when you've accepted and we'll wrap this one up.

[dukenv0307]

@miljakljajic Accepted 🙏

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@miljakljajic)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1809050228518754499/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[miljakljajic]

All contributors paid - closing out