[HOLD for payment 2024-05-09] [$250] [Guided Setup Stage 2] Put the threaded messages in the task description instead

[anmurali]

Coming from this thread.

The onboarding tasks from Concierge to the user looks like this

This is the task pattern and if we did nothing, then it would look the same when these onboarding tasks move to the Expensify system user DM. But this looks very cluttered. For context, we envisioned the ideal design like so

Since Expensify system user chat and tasks are read-only, and we favor the uncluttered approach above, where the details are at the task level but not shown as threaded messages in the main chat - let's implement logic FE for all tasks created by the Expensify system user to hide the threaded messages in the main chat. a change where we move the task messages into the task description field as Jon outlined here. Full Figma examples here.

cc @mountiny @danielrvidal @dubielzyk-expensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0104bc3580ae719595
• Upwork Job ID: 1783858108561276928
• Last Price Increase: 2024-04-26
• Automatic offers:
• rayane-djouah | Contributor | 0

Issue Owner

Current Issue Owner: @twisterdotcom

[dubielzyk-expensify]

Mentioned this in Slack, but my suggestion is moving it to the description which will remove this issue:

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[trjExpensify]

Asking here about what we're doing with this issue.

[rezkiy37]

The PR (#41096) has been opened.

[rezkiy37]

Hey!
I just wanted to let you know about my vacation for next week. I will be back on 06.05.2024. Meanwhile, I asked @waterim to take over this issue.
See you soon!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0104bc3580ae719595

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Guided Setup Stage 2] Hide threaded responses on tasks in the parent chat for the Expensify system user

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

Add below check here here in shouldDisplayThreadReplies function

&& !(ReportActionsUtils.isCreatedTaskReportAction(reportAction)) && reportAction.actorAccountID !== CONST.ACCOUNT_ID.CONCIERGE)

What alternative solutions did you explore? (Optional)

Update this line like bellow

ReportUtils.shouldDisplayThreadReplies(action, report.reportID) && !(ReportActionsUtils.isCreatedTaskReportAction(action) && ReportUtils.isExpensifyOnlyParticipantInReport(report))

[trjExpensify]

This one is being worked on @shahinyan11, sorry! A necessary evil of getting this through the process is the Help wanted label going on momentarily. 👍

[shahinyan11]

@trjExpensify It seems I didn't fully understand the expected result, so I suggested a simple fix, which is not what you need. You can move forward with @rezkiy37's PR

[rezkiy37]

#40998 (comment)

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rayane-djouah]

Reviewing the PR as C+

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve onboarding task description and replies  #41096

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rayane-djouah]

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression test proposal

1. Open the app with an entire new user.
2. Verify that the "What do you want to do today?" modal appears.
3. Select any purpose.
4. Click on "Continue".
5. Verify that the "What’s your name?" modal appears.
6. Enter any names.
7. Click on "Continue".
8. Verify that the app redirects to the home page.
9. Open the Concierge chat.
10. Verify that the app has generated a welcome message and onboarding tasks in Concierge chat.
11. Verify that the onboarding tasks do not have a replies count.
12. Open any onboarding task and verify that the tutorial is in the task description field.

• Do we agree 👍 or 👎

[melvin-bot]

@twisterdotcom, @srikarparsi, @rezkiy37, @rayane-djouah Eep! 4 days overdue now. Issues have feelings too...

[twisterdotcom]

Payment Summary:

• @rezkiy37 does not require payment (Contractor)
• @rayane-djouah paid $250 here (Contributor)