-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] iOS - Group counter in split preview and invite member page blends with the background #41036
Comments
Triggered auto assignment to @lschurr ( |
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-split |
Job added to Upwork: https://www.upwork.com/jobs/~01a9c1b738d03ceaae |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Group counter in split preview and invite member page blends with the background What is the root cause of that problem?The text rendered here seems to get behind the overlay causing it to appear blurred. What changes do you think we should make in order to solve the problem?We should increase the zIndex of counter text to a resonable value: here: Line 2321 in 6acc903
and here: Line 2329 in 6acc903
zIndex: 10 This works perfectly: |
ProposalPlease re-state the problem that we are trying to solve in this issue.The group counter in split preview and invite member page is illegible as the counter blends with the background What is the root cause of that problem?We have Line 765 in 951c7b3
But in IOS zIndex may require Ref: https://reactnative.dev/docs/next/layout-props#zindex What changes do you think we should make in order to solve the problem?We should add App/src/components/MultipleAvatars.tsx Line 241 in 951c7b3
We can add this style to What alternative solutions did you explore? (Optional)NA |
Hi @jayeshmangwani - Can you review the proposals here? |
Thanks for the proposal @neonbhai @nkdengineer, here both the proposals suggests to increase zIndex for 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@jayeshmangwani The RCA of selected proposal isn't clear. It doesn't explain why the bug only happen on IOS. You can test on other platforms and see that this bug doesn't happen. |
@jayeshmangwani @jasperhuangg can you review @nkdengineer comment? #41036 (comment) |
For the child View missing the zIndex, I think @neonbhai 's RCA is valid, though it's not detailed as @nkdengineer, as they have attached a link for the how iOS zIndex prop work differently, but for this simple bug of missing the child View zIndex, I still think @neonbhai 's Proposal is good, what's your thought on this @jasperhuangg |
📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@neonbhai Please raise the PR |
PR ready for review |
@lschurr This issue is ready to be a payout; PR was on the production 10 days ago. Please HOLD my payment for this issue. We are trying to set up the NewDot Payment for me, And I have requested payment for this issue on NewDot. |
Ready to pay this out via New Expensify as soon as we have a payment summary. |
Thanks @jayeshmangwani - looks like the automation didn't work on this one. I'll post the payment summary here. |
Just clarifying @jayeshmangwani - you accepted the offer in Upwork for the job, so it will be paid there rather than in Newdot. Is this incorrect? |
I accepted the offer three weeks ago, and the NewDot payment setup was done two days back, so is there any way to cancel the offer at Upwork, and paid through NewDot ? |
|
Ah, yeah that sounds good. I'll retract the offer in Upwork. |
Payment summary:
|
$250 approved for @jayeshmangwani |
This issue has not been updated in over 15 days. @jasperhuangg, @lschurr, @jayeshmangwani, @neonbhai eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This should be ready to close out, correct? @JmillsExpensify @lschurr |
Gonna go ahead and close this out, feel free to reopen if necessary |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The group counter in split preview and invite member page should be legible
Actual Result:
The group counter in split preview and invite member page is illegible as the counter blends with the background
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: