[$250] Approve - "Waiting for you to pay" message appears briefly for approver after approving report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-2
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR: #40532
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Collect workspace has another user as approver.

1. Go to staging.new.expensify.com
2. [Admin] Go to workspace chat.
3. [Admin] Create an expense and submit the report.
4. [Approver] Go to transaction thread.
5. [Approver] Click Approve button.

Expected Result:

Approver will not be presented with this Next step message "Waiting for you to pay these expenses".

Actual Result:

"Waiting for you to pay these expenses" message appears briefly for approver after approving the report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462601_1714121004492.bandicam_2024-04-26_16-36-46-329.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e61cf7fb38074ac
• Upwork Job ID: 1785010427319132160
• Last Price Increase: 2024-05-14
• Automatic offers:
• eh2077 | Reviewer | 0
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong optimistic message is seen for the approver who is not the owner of the policy

What is the root cause of that problem?

Currently in NextStepsUtils, we do not cover the case where the approver is not the owner of the policy, this causes the current regression, as first we will show the optimistic message which will be set to waiting for you to pay...:

App/src/libs/NextStepUtils.ts

Lines 302 to 308 in 3f379ec

	if (!isOwner) {
	optimisticNextStep.message = [
	{
	text: 'Waiting for ',
	},
	{
	text: managerDisplayName,

here the managerDisplayName would be set to you as :

App/src/libs/NextStepUtils.ts

Line 91 in 3f379ec

const managerDisplayName = isSelfApproval ? 'you' : ReportUtils.getDisplayNameForParticipant(submitToAccountID) ?? '';

isSelfApproval will be true as the current account id would be equal to the approver/submitter account id:

App/src/libs/NextStepUtils.ts

Line 89 in 3f379ec

const isSelfApproval = currentUserAccountID === submitToAccountID;

What changes do you think we should make in order to solve the problem?

We need to add new code which will check if the current user is the approver of the policy but isn't the owner of the policy, and then we will set the optimistic message for this case which will match with the BE returned value:

case CONST.REPORT.STATUS_NUM.APPROVED:
            if (isManager && !isOwner) {
                optimisticNextStep = {
                    type,
                    title: 'Finished!',
                    message: [
                        {
                            text: 'No further action required!',
                        },
                    ],
                };
            } else {
            ..... (The current existing code)

Note: instead of isManager to be more careful we can check submitToAccountID === currentUserAccountID, but that can be discussed during PR stage

Results

Screen.Recording.2024-04-27.at.4.16.23.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e61cf7fb38074ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eh2077]

Commented in the related PR to confirm if this is a legit regression

[allgandalf]

I guess we're good to proceed with the current issue based on this comment #40532 (comment) @eh2077

[eh2077]

reviewing proposals

[eh2077]

When owner and approver are the same person, the behaviour is same as described in this issue (owner and approver are different) after clicking the Approve button - Show Waiting for you to pay these expenses. and then No further action required!

0-admin-and-approver-are-same.mp4

@muttmuure Can you help to clarity the expected behaviours here?

• Case 1: If the owner and approver are different, what should be the next message?
• Case 2: if the owner and approver are same person, what should be the next message?

Note: currently both cases show Waiting for you to pay these expenses. briefly and then show No further action required!

[muttmuure]

Will chat with Tom

[muttmuure]

The owner isn't a factor here, the owner is the person who owns billing

[muttmuure]

https://expensify.slack.com/archives/C036QM0SLJK/p1714555601945619

[eh2077]

@muttmuure So in both cases the next step message will be No further action required! right?

[muttmuure]

Make or track payments is enabled, so there should be an action to pay, it just depends who it is - I will revert back soon

[eh2077]

Make or track payments is enabled, so there should be an action to pay, it just depends who it is - I will revert back soon

@muttmuure Sorry, the expected results are still not clear to me. Looking forward to your update, thanks.

[eh2077]

Waiting for update from @muttmuure

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[muttmuure]

If Make and track payments is enabled but no bank account is connected, the message Waiting for you to pay these expenses should be showing for all admins.

So the unexpected behavior here is that No further action required is showing at all. It should be Waiting for you to pay these expenses

[eh2077]

@muttmuure Thank you for making that clear.

@GandalfGwaihir Can you update your proposal based on @muttmuure 's comment ^?

[eh2077]

@GandalfGwaihir Friendly bump!

[melvin-bot]

@muttmuure @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[allgandalf]

So the unexpected behavior here is that No further action required is showing at all. It should be Waiting for you to pay these expenses

I think you understood the issue wrong here @muttmuure , it indeed shows Waiting for you to pay these expenses for all admins.

The bug here is for approver (The person who is an approver but not the admin/owner of the workspace). In this case we optimistically set the message to Waiting for you to pay these expenses and then the BE returns no actions needed (which is right as the approver doesn't have the authority to pay the expense as he is neither the admin nor owner).

So I guess my proposal still is valid for the bug described in the OP.

What are your thoughts @muttmuure @eh2077 , sorry for the delay in reply

[eh2077]

The bug here is for approver (The person who is an approver but not the admin/owner of the workspace). In this case we optimistically set the message to Waiting for you to pay these expenses and then the BE returns no actions needed (which is right as the approver doesn't have the authority to pay the expense as he is neither the admin nor owner).

This makes sense to me if we only want to fix this specific use case.

But I think it'll be better to fix #41081 (comment) together as they're relevant.

@GandalfGwaihir What do you think?

cc @muttmuure

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[allgandalf]

@GandalfGwaihir What do you think?

I am Okay with that, but for this to happen we also need a BE fix right, cause the message No further action required is set fro the BE, we can make the FE changes to set the message optimistically, but BE should also be async, but I think the discussion we had is sufficient for us to proceed with PR

[eh2077]

@GandalfGwaihir Thanks for the update!

I think we can go with @GandalfGwaihir 's proposal to move this issue forward.

Apart from fixing the specific case as described by this issue, I think we can also fix similar cases together. Yes, these cases also need backend fix.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

@eh2077 I will open the PR over the weekend/ as soon as the BE issues are resolved, sorry for delay, due to the current site reliability issues with ND it's really difficult for me to test the changes, I am getting error every time I submit an expense or even try to approve it 😢 , will post when the PR is up

[allgandalf]

PR ready for review @eh2077 , thanks for the patience

[allgandalf]

@muttmuure , can you take a look at this comment from the PR once you find time :)

[yuwenmemon]

As mentioned here, this issue was fixed by another PR while this one was on hold for the merge freeze. We'll still pay @GandalfGwaihir and @eh2077 for their fix though cc @muttmuure (https://stackoverflowteams.com/c/expensify/questions/8719)

[allgandalf]

can you pay this one please @muttmuure :)

[muttmuure]

All paid up