-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-20] [$250] iPhone 13 PRO/chrome - Continue
button is cut off at the bottom in sign in screen
#41108
Comments
Triggered auto assignment to @miljakljajic ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
@miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I wasn't able to reproduce this. I'll see if anyone in QA can. |
@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Continue
button is cut off at the bottom in sign in screenContinue
button is cut off at the bottom in sign in screen
Job added to Upwork: https://www.upwork.com/jobs/~0197bc982a483fb96d |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
Kavi was able to reproduce, adding external label to be worked on. |
@miljakljajic @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@miljakljajic, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue, still waiting for proposals |
ProposalPlease re-state the problem that we are trying to solve in this issue.The virtual viewport on the Webkit-based browsers is not reset when focusing on the input What is the root cause of that problem?We have 2 issues here:
I have resolve #19642 only for Issue 2: We don't handle scroll the button into the view when focusing on the input What changes do you think we should make in order to solve the problem?Fix issue 1: const isAvoidingViewportScroll = useTackInputFocus(shouldEnableMaxHeight && shouldAvoidScrollOnVirtualViewport && Browser.isMobileWebKit()); Fix issue 2: + const submitContainerRef = useRef<View | HTMLDivElement>(null);
+ const handleFocus = useCallback(() => {
+ InteractionManager.runAfterInteractions(() => {
+ htmlDivElementRef(submitContainerRef).current?.scrollIntoView?.({behavior: 'smooth', block: 'end'});
+ });
+ },[])
return (
<>
<View
accessibilityLabel={translate('loginForm.loginForm')}
style={[styles.mt3]}
>
<TextInput
ref={input}
+ onFocus={handleFocus}
....
isVisible && (
+ <View style={[shouldShowServerError ? {} : styles.mt5]} ref={viewRef(submitContainerRef)}> What alternative solutions did you explore? (Optional)Issue 1: Create new function check onFocus={() => {
const isChromeIOS = () => {
const userAgent = navigator.userAgent;
return /CriOS/i.test(userAgent); // Checks if 'CriOS' (Chrome for iOS) is present
}
if (isChromeIOS()) {
InteractionManager.runAfterInteractions(() => {
window.scrollTo({top: 0});
});
// OR window.visualViewport?.addEventListener('scroll', resetScrollPositionOnVisualViewport);
}
}} Issue 2: Instead of keep |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@miljakljajic, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Still working on the PR |
Continue
button is cut off at the bottom in sign in screenContinue
button is cut off at the bottom in sign in screen
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Checklist
|
Not overdue, we're just waiting for @miljakljajic to handle the payment |
payment completed |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713929851923959
Action Performed:
Precondition: User should have saved credentials in keychain or password
Expected Result:
Continue button is visible
Actual Result:
Keyboard covers half of the continue button
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @miljakljajicThe text was updated successfully, but these errors were encountered: