[HOLD for payment 2024-06-06] [$250] IOS - Video - Video sound is not playing when device sound profile is silent mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

• Version Number: 1.4.67-0
• Reproducible in staging?: y
• Reproducible in production?: y
• Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Device sound mode is not silent mode.

1. Launch New Expensify app.
2. Go to chat.
3. Upload a video with sound.
4. Play the video.
5. Note that the sound is playing.
6. Change the device sound mode to silent mode.
7. Play the video.

Expected Result:

The video sound should play as long as the media volume is not zero.

Actual Result:

The video sound is not playing when device sound profile is silent mode.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop
• Screenshots/Videos

Add any screenshot/video evidence

Bug6464967_1714383898597.RPReplay_Final1714383538__1_.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Video sound is not playing when device sound profile is silent mode in iOS.

What is the root cause of that problem?

This is the default functionality of expo-av in iOS.

What changes do you think we should make in order to solve the problem?

Add the below in Expensify.tsx. This will enable media volume in silent mode for iOS.

useEffect(() => {
    Audio.setAudioModeAsync({ playsInSilentModeIOS: true })
}, []);

We can add in BaseVideoPlayer instead, but Expensify.tsx would be a better choice.

What alternative options did you explore?

We can update the AppDelegate.m file to add the below line in didFinishLaunchingWithOptions.

[[AVAudioSession sharedInstance] setCategory:AVAudioSessionCategoryPlayback error:nil];

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b7c5dab39a2df1f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[abekkala]

@getusha we do have one proposal already for this one!

[getusha]

@abekkala @kbecciv is there a reproduction step? is it only on iOS?

[kbecciv]

@abekkala Can you please bring the OP back? Thank you!

[melvin-bot]

@abekkala, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@abekkala Can you please bring the OP back? Thank you!

Odd, yes I put it back!

[abekkala]

@getusha OP is back - @kbecciv reported this as affecting iOS: Native

[melvin-bot]

@abekkala, @getusha Huh... This is 4 days overdue. Who can take care of this?

[getusha]

Will try reproducing this & we have a proposal to review

[getusha]

Asked another c+ with a physical iOS device https://expensify.slack.com/archives/C02NK2DQWUX/p1715517674210059
@c3024 will take it.

[c3024]

@ShridharGoel 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

Is this a feature and not a bug?

[c3024]

It is a feature of iOS native.

But this iOS native behaviour is different from Android native, Android Chrome and iOS Safari. In these three, video sound continues to play even after changing the device to silent mode. This inconsistency can be considered as a bug.

[MonilBhavsar]

Thanks for clarifying!

[c3024]

@ShridharGoel any update on this?

[ShridharGoel]

@c3024 #42366

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Play sound even when device is silent - iOS #42366

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment (Needs manual offer from BZ)
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR JUN 06

• Fix: @ShridharGoel [$250] Offer Link
• PR Review: @c3024 [$250] Offer Link Please complete checklist above

[c3024]

The PR that introduced the bug has been identified. Link to the PR:

No specific PR can be made responsible for this. This is a specific iOS behaviour.

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No discussion was started as this is a particular iOS specific behaviour and cannot be identified earlier.

Determine if we should create a regression test for this bug.

Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Switch iOS device to silent mode.
2. Keep the media volume on.
3. Go to any chat and play a video with audio.
4. Verify that the sound is audible.

👍 or 👎

[c3024]

@abekkala thanks, accepted.

[abekkala]

@c3024 - payment sent and contract ended - thank you! 🎉

[abekkala]

@ShridharGoel can you please accept the offer in Upwork so that I can submit payment and close this one? Offer Link thanks!

[abekkala]

@ShridharGoel payment sent and contract ended - thank you! 🎉