Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-03] [$250] Workspace - Workspace name is truncated inconsistently in mWeb and android #41327

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 30, 2024 · 36 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open mweb and android app
  2. Tap profile --- Workspaces---new Workspace
  3. Tap profile
  4. Paste text in both mweb and app-RtTest Workspace testingtestingtestingtestingtestingtestinggghhhhhhggggggf722222222222mmmmmmmmmmmmm7

Expected Result:

Workspace name truncated must be consistent in mweb and android

Actual Result:

Workspace name is truncated inconsistently in mweb and android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466484_1714480580012!Screenshot_2024-04-30-18-05-58-555_com android chrome-edit

Bug6466484_1714480627044!Screenshot_2024-04-30-18-06-38-862_com expensify chat-edit

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106a5ae69cbfb2cf2
  • Upwork Job ID: 1785354421533896704
  • Last Price Increase: 2024-04-30
  • Automatic offers:
    • getusha | Reviewer | 0
    • Krishna2323 | Contributor | 0
Issue OwnerCurrent Issue Owner: @garrettmknight
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0106a5ae69cbfb2cf2

@melvin-bot melvin-bot bot changed the title Workspace - Workspace name is truncated inconsistently in mWeb and android [$250] Workspace - Workspace name is truncated inconsistently in mWeb and android Apr 30, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@Krishna2323
Copy link
Contributor

Krishna2323 commented Apr 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace name is truncated inconsistently in mWeb and android

What is the root cause of that problem?

The title doesn't take the full width because flex1 isn't applied to workspaceTitleStyle.

App/src/styles/index.ts

Lines 4851 to 4854 in 1abad69

workspaceTitleStyle: {
...headlineFont,
fontSize: variables.fontSizeXLarge,
},

What changes do you think we should make in order to solve the problem?

Apply flex:1/styles.flex1 to workspaceTitleStyle style object and also check for similar issues in other fields.

What alternative solutions did you explore? (Optional)

Add flex1 to menu item title and description if needed.

Before

before_workspace_title_truncate_issue.mp4

After

after_workspace_title_truncate_issue.mp4

@Krishna2323
Copy link
Contributor

Proposal Updated

  • Added alternative
  • Added fix videos

@getusha
Copy link
Contributor

getusha commented May 1, 2024

@tienifr didn't we fix this before?

@tienifr
Copy link
Contributor

tienifr commented May 2, 2024

@getusha Hmm I'm not sure, I've been working on many PRs relating to truncation. Could you link the PR you mentioned?

@getusha
Copy link
Contributor

getusha commented May 2, 2024

@tienifr here, this one #40824
I copied your PR to fix some conflicts.

@tienifr
Copy link
Contributor

tienifr commented May 3, 2024

I think we missed that case on Android, the PR was merged too fast. But this issue is external and the solution from @Krishna2323 will fix the issue. Should we fix that problem here? @getusha

@getusha
Copy link
Contributor

getusha commented May 3, 2024

Actually after a closer look, looks like it's on a different place. Workspace profile and Workspace list.

@getusha
Copy link
Contributor

getusha commented May 3, 2024

@Krishna2323 why was this happening only on android native?

@Krishna2323
Copy link
Contributor

@getusha, this is a known issue in android native, the text component doesn't fill up the space automatically. We have already applied flex1 to fix this issue in many places, e.g., #30222.

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@getusha
Copy link
Contributor

getusha commented May 6, 2024

@Krishna2323's proposal looks good to me
🎀 👀 🎀 C+ Reviewed!

Copy link

melvin-bot bot commented May 6, 2024

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hayata-suenaga
Copy link
Contributor

I agree that @Krishna2323's proposal looks good.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 6, 2024
Copy link

melvin-bot bot commented May 6, 2024

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented May 27, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 27, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 27, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@getusha] Determine if we should create a regression test for this bug.
  • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 2, 2024
@garrettmknight
Copy link
Contributor

garrettmknight commented Jun 3, 2024

@getusha can you complete the checklist when you get a minute? And accept the offer in Upwork?

@garrettmknight
Copy link
Contributor

garrettmknight commented Jun 3, 2024

Payment Summary:

@getusha
Copy link
Contributor

getusha commented Jun 4, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: #36426
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 2b9a9b0#r142705070
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. No
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

@garrettmknight
Copy link
Contributor

@getusha thanks - please accept the offer in Upwork and I'll pay it out.

@getusha
Copy link
Contributor

getusha commented Jun 4, 2024

@getusha thanks - please accept the offer in Upwork and I'll pay it out.

@garrettmknight i am working on migrating to ND payments, could we hold this for a little longer?

@garrettmknight
Copy link
Contributor

Fine by me - ping me when you're ready!

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 12, 2024
@garrettmknight
Copy link
Contributor

Just waiting for NewDot Payment.

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2024
@hayata-suenaga
Copy link
Contributor

Melvin, we're just waiting for payment 😄

@garrettmknight
Copy link
Contributor

Yep, just waiting for payment!

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@getusha
Copy link
Contributor

getusha commented Jun 27, 2024

@garrettmknight just found out i should be paid via UW on issues assigned before 2024-05-25
could you send the upwork offer? i am unable to find it. thanks!

@garrettmknight
Copy link
Contributor

Np, just sent you an offer. https://www.upwork.com/ab/applicants/1806378912766645315/offers

@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 labels Jun 27, 2024
@getusha
Copy link
Contributor

getusha commented Jun 27, 2024

Accepted!

@garrettmknight
Copy link
Contributor

All paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Development

No branches or pull requests

6 participants