[HOLD for payment 2024-06-03] Send invoice - Each workspace avatar in sender list has the same avatar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has a few workspaces with default and custom workspace name.

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Enter amount and select a participant.
4. Click on the workspace.

Expected Result:

Each workspace avatar is displayed correctly.

Actual Result:

Each workspace avatar in sender list has the same avatar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467469_1714543804926.invoice_sender_avatar.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-bills

[izarutskaya]

Production

[ra-md]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Each workspace avatar in send invoice sender list has the same avatar

What is the root cause of that problem?

There is no policy ID in the activeAdminWorkspaces icons.

App/src/pages/iou/request/step/IOURequestStepSendFrom.tsx

Lines 48 to 55 in 5f50430

	icons: [
	{
	source: policy?.avatar ? policy.avatar : ReportUtils.getDefaultWorkspaceAvatar(policy.name),
	fallbackIcon: Expensicons.FallbackWorkspaceAvatar,
	name: policy.name,
	type: CONST.ICON_TYPE_WORKSPACE,
	},
	],

What changes do you think we should make in order to solve the problem?

Add id: policy.id to the icons.

    icons: [
        {
            id: policy.id,
            source: policy?.avatar ? policy.avatar : ReportUtils.getDefaultWorkspaceAvatar(policy.name),
            fallbackIcon: Expensicons.FallbackWorkspaceAvatar,
            name: policy.name,
            type: CONST.ICON_TYPE_WORKSPACE,
        },
    ],

We also need to do the same in MoneyRequestConfirmationList.tsx

<MenuItem
    id={senderWorkspace?.id}
    key={translate('workspace.invoices.sendFrom')}
    shouldShowRightIcon={!isReadOnly && canUpdateSenderWorkspace}
    title={senderWorkspace?.name}
    icon={senderWorkspace?.avatar ? senderWorkspace?.avatar : getDefaultWorkspaceAvatar(senderWorkspace?.name)}
    iconType={CONST.ICON_TYPE_WORKSPACE}
    description={translate('workspace.common.workspace')}
    label={translate('workspace.invoices.sendFrom')}
    isLabelHoverable={false}
    interactive={!isReadOnly && canUpdateSenderWorkspace}
    onPress={() => {
        Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_SEND_FROM.getRoute(iouType, transaction?.transactionID ?? '', reportID, Navigation.getActiveRouteWithoutParams()));
    }}
    style={styles.moneyRequestMenuItem}
    labelStyle={styles.mt2}
    titleStyle={styles.flex1}
    disabled={didConfirm || !canUpdateSenderWorkspace}
/>

MenuItem.tsx

    <Avatar
        accountID={id}
        imageStyles={[styles.alignSelfCenter]}
        size={CONST.AVATAR_SIZE.DEFAULT}
        source={icon as AvatarSource}
        fallbackIcon={fallbackIcon}
        name={title}
        type={CONST.ICON_TYPE_WORKSPACE}
    />

What alternative solutions did you explore? (Optional)

N/A

[MonilBhavsar]

A minor UI issue not worth a blocker.
Have commented in the offending PR #39637 (comment)

[grgia]

@nkdengineer

[grgia]

@rushatgabhane this is a regression from #39637 (comment)

[rushatgabhane]

Send invoice wasn't a thing back then 😭
Anyway, @nkdengineer could you please raise a PR

[MonilBhavsar]

Send invoice wasn't a thing back then 😭

Hmm, Send Invoice PR is on production and this is on staging. So i wonder if it is the case 🤔

[nkdengineer]

@MonilBhavsar @grgia I will raise the PR to fix this today. It's hard to keep track this bug because it's merged while my PR is in review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: regressions related to workspace avatars #41485

If no regressions arise, payment will be issued on 2024-06-03. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[adelekennedy]

@MonilBhavsar @grgia I don't think any payment is due here, have I missed something?