-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Workspace Avatar Color based on PolicyID instead of Workspace Name #39637
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Looks good from a design standpoint. |
Dangit Shawn you beat me by ONE minute! 😂 |
@rushatgabhane friendly bump |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-15.at.21.56.33.moviOS: Nativehttps://github.com/Expensify/App/assets/29673073/68618c7f-2136-4ad9-962b-b25f791b6f12MacOS: Chrome / SafariScreen.Recording.2024-04-11.at.04.31.46.movScreen.Recording.2024-04-15.at.21.50.34.movMacOS: DesktopScreen.Recording.2024-04-11.at.04.30.00.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkdengineer bug: the workspace switcher has same color for all workspaces
- On top left in LHN, click the Expensify icon to open workspace picker
@nkdengineer how's it looking? |
@rushatgabhane please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor questions
src/components/Avatar.tsx
Outdated
/** ID of the Icon */ | ||
iconID?: number | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** ID of the Icon */ | |
iconID?: number | string; | |
/** ID of the Icon */ | |
policyID?: number | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are we passing the accountID otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grgia i updated, please check again
@@ -49,6 +49,9 @@ type AvatarProps = { | |||
|
|||
/** Owner of the avatar. If user, displayName. If workspace, policy name */ | |||
name?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I guess the first letter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
Running a test build to do a quick QA |
@grgia Updated to fix this case. |
@nkdengineer could you merge main? |
Apologies for the delay |
@grgia I merged. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
@nkdengineer sorry one last merge main, please ping me! |
@grgia Merged main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 Deployed to staging by https://github.com/grgia in version: 1.4.69-0 🚀
|
@nkdengineer @grgia we have a regression from this PR #41385 |
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀
|
Details
Fixed Issues
$ #39478
PROPOSAL: #39478 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web-resize.mp4
MacOS: Desktop
desktop-resize.mp4