[HOLD for payment 2024-06-05] [$250] [Track Tax] Unable to save tax amount which is below the limit for scan request

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace has a few tax rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a scan expense with a valid receipt.
4. After the scanning is complete, go to transaction thread.
5. Click Tax.
6. Change to a different (non-zero) tax rate.
7. Click Tax amount.
8. Enter any tax amount as long as it is below the limit.
9. Save it.

Expected Result:

App will save the tax amount as long as it is below the limit.

Actual Result:

App is unable to save the tax amount. Error "Maximum tax amount is MYR 0.00" shows up.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6467985_1714572683757.20240501_220445.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0147258a467490a0c2
• Upwork Job ID: 1785767395280666624
• Last Price Increase: 2024-05-01
• Automatic offers:
• shubham1206agra | Reviewer | 0
• Nodebrute | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[blimpich]

@Krishna2323 @Ollyws looks like it might be related to #41264. Can you take a look?

[Krishna2323]

@blimpich, I don't think this is caused by this PR. The isTaxAmountInvalid returns true because the taxAmount (max amount) we receive from props is 0 after the receipt is scanned. We were able to save an invalid amount before our PR, but now the validation works, and the taxAmount is zero, so it throws an error.

App/src/pages/iou/MoneyRequestAmountForm.tsx

Lines 70 to 71 in 406139c

	const isTaxAmountInvalid = (currentAmount: string, taxAmount: number, isTaxAmountForm: boolean) =>
	isTaxAmountForm && Number.parseFloat(currentAmount) > CurrencyUtils.convertToFrontendAmount(Math.abs(taxAmount));

[blimpich]

Chatted in slack here, going to treat this as a separate issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0147258a467490a0c2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[blimpich]

Not a blocker I think, though I am a little on the fence here. I think that since collect in new dot is still new and this seems more like a polish item it can be considered not a blocker.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to save tax amount which is below the limit for scan request

What is the root cause of that problem?

Here we are passing taxAmount which we are getting from getTaxAmount and we are passing transaction.

App/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx

Line 153 in 1c651a1

taxAmount={getTaxAmount(transaction, taxRates, Boolean(backTo || isEditing))}

In getTaxAmount we return early if we don't have amount. In case of scan the transaction.amount will be 0 and this function will return early.

App/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx

Lines 38 to 40 in 1c651a1

	if (!transaction?.amount) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We should add a check if transaction.amount is 0 then check for modifiedAmount. And if modifiedAmount is present then don't return early.

We can do something like this (Pseudocode)

// If neither `amount` nor `modifiedAmount` is present, return early
 if (!transaction?.amount && !transaction?.modifiedAmount) {
        return;
    }

What alternative solutions did you explore? (Optional)

Instead of passing transaction to the getTaxAmount function, we can use transactionDetails here and adjust the code.

[isabelastisser]

Bump @blimpich to review the proposal and assign @Nodebrute. Thanks!

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix scan tax error #42024

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Hey, @shubham1206agra, please complete the BZ list above. Thanks!

[isabelastisser]

Payment processed in Upwork for @Nodebrute!

@shubham1206agra, your offer is still pending in Upwork. Please accept it and I will process the payment. Thanks!

[isabelastisser]

Bumo @shubham1206agra to accept the offer in Upwork and update the BZ checklist above. I will DM you for visibility, thanks!

Closing.

[isabelastisser]

Hey @shubham1206agra, can you please complete the checklist? Thanks!

#41434 (comment)

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage to TypeScript #39059
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39059/files#r1631024134
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: