[$250] Send invoice - App crashes after creating invoice

[m-natarajan]

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[CortneyOfstad]

Was able to recreate this pretty quickly:

2024-05-02_10-03-14.mp4

The request does show up fine in my app without error or issue in production:

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - App crashes after creating invoice

What is the root cause of that problem?

Top report could not found at this line before access

What changes do you think we should make in order to solve the problem?

We should check topReport before access it

        if (!!topReport && topReport.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED) {
            return false;
        }

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

Looks like regression from this PR #39297

[m-natarajan]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - App crashes after creating invoice.

What is the root cause of that problem?

topReport can be undefined here:

  if (topReport.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED) {
      return false;
  }

What changes do you think we should make in order to solve the problem?

Update it to this:

if (topReport && topReport.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED) {
    return false;
}

[grgia]

@dragnoir @DylanDylann could you confirm #41504 (comment)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc95f2cc344909b1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[dragnoir]

@grgia I can create a PR to fix this

[grgia]

@DylanDylann @dragnoir assigning as a regression follow up

[francoisl]

@dragnoir Hi, just checking in - do you think you will you be able to submit a PR for this today?

[dragnoir]

@francoisl PR ready

[CortneyOfstad]

PR CPd for staging. Will continue to keep an eye on this 👍

[CortneyOfstad]

Was deployed to production 4 days ago!

[CortneyOfstad]

PR was deployed to production on May 6th — payment is being handled via the main GH here, so this can be closed 👍