[HOLD for payment 2024-06-11] [$250] Web - Accounting - Xero - Console error shows up when opening Preferred exporter

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #41641
Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace is connected to Xero.

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go to Accounting.
4. Go to Export.
5. Click Preferred exporter.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481656_1715779259909!staging.new.expensify.com-1715778677003.txt

Bug6481656_1715779259903.bandicam_2024-05-15_21-11-02-900.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f939b9bc571e795d
• Upwork Job ID: 1791257784808251392
• Last Price Increase: 2024-05-17
• Automatic offers:
• ahmedGaber93 | Reviewer | 0
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @twisterdotcom

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Beamanator]

@twisterdotcom this can probably be external, but it's probably a super quick fix from whoever is working on Xero stuff (@hayata-suenaga or @lakchote maybe?)

[twisterdotcom]

Agree, we should assign whoever worked on this last. Will wait for @hayata-suenaga and @lakchote to chime in.

[hayata-suenaga]

@lakchote, might be related around this line where we navigate to the preferred exporter page? Anyway, this also looks navigation-related. Should we make this issue external?

[twisterdotcom]

Okay, we can make it external. Seems it might be quicker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f939b9bc571e795d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error shows up.

What is the root cause of that problem?

We're using slash at the beginning of route and getRoute, it cause the push action error

App/src/ROUTES.ts

Lines 819 to 820 in e8ae3c5

	route: '/settings/workspaces/:policyID/connections/xero/export/preferred-exporter/select',
	getRoute: (policyID: string) => `/settings/workspaces/${policyID}/connections/xero/export/preferred-exporter/select` as const,

What changes do you think we should make in order to solve the problem?

We should remove the slash at the beginning in route and getRoute function of POLICY_ACCOUNTING_XERO_PREFERRED_EXPORTER_SELECT like other routes

    POLICY_ACCOUNTING_XERO_PREFERRED_EXPORTER_SELECT: {
        route: 'settings/workspaces/:policyID/connections/xero/export/preferred-exporter/select',
        getRoute: (policyID: string) => `settings/workspaces/${policyID}/connections/xero/export/preferred-exporter/select` as const,
    },

We should remove slash in POLICY_ACCOUNTING_XERO_CUSTOMER too

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-05-17.at.14.56.08.mov

[lakchote]

I do agree with @Beamanator, we've probably could have waited I woke up to handle this, as the fix is really simple and it's just a console error 😅

Anyway let's wait for @ahmedGaber93 review of @tienifr's proposal, but it looks good to me.

[ahmedGaber93]

@tienifr Thanks for the proposal.

I agree with @lakchote. @tienifr's proposal looks good, the react-navigation read the route path that starting with // as absolute URL not relative URL which cause error is the browser history and URL.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@tienifr's proposal LGTM

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ahmedGaber93]

@tienifr please let me know when PR is ready.

[tienifr]

@ahmedGaber93 I'll raise the PR in a hour

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Console error shows up when opening Preferred exporter #42372

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment Summary:

• @ahmedGaber93 paid $250 here (Reviewer)
• @tienifr paid $250 here (Contributor)

I don't think we need a test case for a console error here.