Chat - For quote, live markdown is not shown

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4582241
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Enter >hai
4. Send the message
5. Long tap and open edit comment

Expected Result:

For quote, live markdown must be shown

Actual Result:

For quote, live markdown is not shown but in edit comment markdown is shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6495011_1716981088204.Screenrecorder-2024-05-29-16-37-20-185_compress_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

@abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[izarutskaya]

Production

Record_2024-05-29-14-47-16.mp4

[Julesssss]

This shouldn't block the app, it's a minor UI issue, likely introduced as part of the recent live-markdown library bump

[Julesssss]

I shared this in the live markdown Slack channel here

[Skalakid]

Hi, I'm Michał from SWM and I will investigate this problem

[Skalakid]

After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after >. I will create PR that bumps the version in the Expensify App

[Skalakid]

@Julesssss I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue now

[Julesssss]

Ah thanks for taking a look. Let me confirm

[Julesssss]

@izarutskaya, is this bug report for the case where no space is left between the chevron and text? For example:

>text

[Skalakid]

@Julesssss the problem is with the representation of the chevron and text inside the input and message. However, I'm not able to reproduce this issue on the latest main. Let me know if it works on your end

[Julesssss]

I agree that's the reported problem, but I think the distinction is between >test and > test.

>test works for me in production, but not staging and dev
> test works in all environments

[Skalakid]

Yes, and >test should not work, it's a new change. I'm not sure if this issue is reproducible, let me know if it's working on your end. The only change that we can do is to update expensify-common in E/App and react-native-live-markdown, but we will do it together with code block PR

[Julesssss]

I can reproduce >test not rendering, but as you say above, this is expected 👍

@Skalakid do you have a link to the code block PR/issue? I see this one, but it sounds like regular text.

[melvin-bot]

@Julesssss @abekkala this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Julesssss]

Closing, this was an expected change