[HOLD for payment 2024-06-20] [$250] Web-Not found - LHN shows weird animation and becomes unresponsive after invoice deeplinking

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-2
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #41730
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Deep link to send invoice (e.g https://staging.new.expensify.com/create/invoice/start/1/7783051691252045
   )
3. Click on the back icon of the not found RHP
4. Click on Settings

Expected Result:

RHP closes with the right animation and LHN becomes responsive

Actual Result:

RHP closes with a weird animation and LHN becomes stuck and unresponsive when opening settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6497048_1717134820381.bandicam_2024-05-31_08-49-52-962.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01adb4996302fbbbfc
• Upwork Job ID: 1796610903877054464
• Last Price Increase: 2024-05-31
• Automatic offers:
• shubham1206agra | Contributor | 102545412

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

[cristipaval]

Removed the deploy blocker as per this plan. Let's assign @tienifr to fix and @shubham1206agra for the c+ review, since they are the authors of the original PR 🙏

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01adb4996302fbbbfc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[johncschuster]

Sorry about the tag, @DylanDylann. We're assigning this one out to @tienifr and @shubham1206agra.

@tienifr can you comment on the issue so I can assign this to you?

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

Please.

[tienifr]

I opened PR above ^

[shubham1206agra]

@johncschuster, please close this as it does not require any payment.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: go back in AccessOrNotFoundWrapper #42976

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Will be paying this out on the 20th if there are no regressions. @shubham1206agra, can you complete the BZ Checklist above before then? Thank you!

[shubham1206agra]

@johncschuster No payment is required here. It was being handled as a regression.

[johncschuster]

Got it. Thanks, @shubham1206agra! Is there a regression test already out there for this, or should we create one?

[johncschuster]

@shubham1206agra bump on the above question!

[shubham1206agra]

@johncschuster We already have a test as this was a deploy blocker.

[johncschuster]

@shubham1206agra Great! In that case, it sounds like we can close this one.