Deploy Checklist: New Expensify 2024-05-30

[github-actions]

Release Version: 1.4.78-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add offline search functionality for addresses #35045
• [No QA] Replace usages of useWindowDimensions with useResponsiveLayout in components folder #36292
• [ImgBot] Optimize images #37695
• Update redirects community pages to help.dot #38644
• Add support for Latin characters in emoji suggestion #39805
• [Fix]: Tapping outside quickly after clear status leads the user going back to the report screen #40364
• Show console debug logs via test tools menu #40656
• fix error when clicking on attachment note #40844
• Update rn-web to 0.19.12 #40960
• fix: check if image is rotated before cropping #40971
• [Wave Collect][Xero][Advanced] Bill status selector page #41559
• Add sync functionality in Xero connection #41562
• fix Self DM doesn't scroll down #41634
• Access control on IOU request #41730
• Fix InitialUrlContextProvider for HybridApp #41764
• feat: add PromotedActionsBar #41972
• Add proper offline state handling for XeroOrganizationConfigurationPage #41983
• DOCS: Create Update-your-Expensify-Card-mailing-address.md #41994
• Fix archived invoice room titles #42085
• Don't navigate to public screen deep link after sign in #42130
• [NoQA] Add orderWeight to tag view and tag edit routes #42149
• Bump expensify-common version #42176
• Make taxes read-only when connected to accounting integration #42192
• Create "Hidden" folder in helpsite repo to house delisted articles #42222
• Fix split amount input does not animate smoothly #42241
• [NO QA] Fix values of EXPORTED_* actions #42242
• [Search v1] Add sorting  #42248
• [No QA][TS migration] Remove all remaining prop-types from the project #42249
• DOCS: Create Dispute-Expensify-Card-transaction.md #42280
• Add error message in case of integration sync failure #42307
• Enable / Disable multi level tags #42315
• fix: console error on xero customers page. #42324
• Merge Xero freeze branch #2 #42340
• [Wave Collect][Xero] Hide guides as exporters #42346
• [Wave Collect][Xero] Tracking categories fixes #42347
• [Wave Collect] [Xero] Default select options #42360
• fix: group chat with one member shows in start chat list #42363
• Emoji is being deleted by itself fix #42367
• Console error shows up when opening Preferred exporter #42372
• [Wave Collect] [Xero] Fix: When you click “Sync now” you see the Quickbooks Online text very briefly #42383
• chore: update search results ordering #42411
• Fix user can submit 10-digit amount and gives an unexpected error #42426
• fix: navigate back directed to Workflows page instead of Get assistance page #42459
• Fix taxes not blocked with accounting integration connected #42461
• [Wave Collect] [Xero] Make the integration name in Categories dynamic  #42462
• [Wave Collect] [Xero] Disable taxes if previously enabled when connecting to QBO #42467
• [Xero] Remove overflow menu from accounting header #42468
• fix: customize size behavior of image component #42469
• [Wave Collect] [Xero/QBO] Update educational messages #42487
• Add empty subscription settings screen to navigation #42514
• Create Tag utils file #42559
• fix: User is already a member of the Workspace message is missing #42569
• Fix tracking categories not dynamic  #42593
• Fix emoji’s are cut in half when in Edit message mode #42615
• [Wave collect] [Xero] Block Xero screens if Xero is not connected. #42619
• fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode. #42620
• Fix language for consistent use of "with Expensify" #42658
• Only show receipt-related violations in receipt audit #42661
• [Wave Collect] [Xero] More features text #42662
• Fix start chat page closes immediately after creating a room while offline #42679
• [Snyk] Security upgrade react-native from 0.73.4 to 0.73.5 #42700
• Update redirects.csv #42718
• [CP Staging] Fix unable to add custom tag name in a new workspace #42734
• Fix AvatarWithImagePicker error styles #42735
• Merge the feature-payment-card-subscription feature branch into main #42754
• [NO QA] Update split participants copy #42779
• Fix button wording for consistency #42790
• [NoQA] Fix type for UserUtils #42808
• Define & hide any deprecated report actions from OldDot #42811
• Revert "[Snyk] Security upgrade react-native from 0.73.4 to 0.73.5" #42846
• [CP Staging] Revert "Bump expensify-common version" #42914
• [CP Staging] Use modal context provider to fix useResponsiveLayout #43013

Deploy Blockers:

• [$250] Android-Room-After creating room, entering @ not showing contact suggestions #42766
• Sign in - Unable to Google/Apple sign in #42807
• [HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] Tags - Console error when disabling tag when created offline on web, app crashes on iOS #42885
• Tags - Delete pop-up briefly appears expanded at the bottom after deleting tag #42886
• iOS - Edit comment - App crashes when editing comment containing user mention #42888
• [Search v1] New Search Page - Page shows blank UI #42889
• Android - Room mention - App crashes when copying #announce to clipboard #42890
• Emoji - When editing an emoji only message, the "Composer" is expanded #42891
• [HOLD for payment 2024-06-20] [$250] Chat - Unable to open chat if going back from not found page after using send invoice link #42902
• [HOLD for payment 2024-06-13] More feature Popup - Text under "not so fast" quickly disappears & slightly shrinks popup #42903
• [HOLD for payment 2024-06-20] [$250] Web-Not found - LHN shows weird animation and becomes unresponsive after invoice deeplinking #42906
• [$250] Web - Tags - 3-dot menu in tag RHP animation stutters #42908
• [HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [HOLD #42911] Workspace chat - "Remove members" pop-up slides up from the bottom to the center #42910
• [HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] "Upload Photo" Popup Jitters When Clicking on Group Avatar #42911
• [HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] Unable to open composer + menu and FAB menu after refreshing RHP #42912
• Accounting - Error shows up while connecting to Xero for the first time #42913
• [$250] Taxes - Edited tax is not grayed out in Tax list in submit manual flow #42918
• Workspace - "Add" and "Delete" options aren't visible after disconnecting Xero #42920
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline #42957
• Accounting - User need no sync Xero integration after connection #42992

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[kavimuru]

Checking off PRs which are in past builds
#35045
#41764
#42426

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.78-2 🚀

[Julesssss]

#42911 is a small UI issue. Not worth blocking

[twisterdotcom]

Checking off #42913 as it doesn't block behaviour and Xero is still behind a beta.

[Beamanator]

Downgrading #42908 as NAB

[rlinoz]

Checking off #42891, working as intended.

[cristipaval]

Demoting #42902 and #42906

[kavimuru]

Regression is at 94%
Unchecked PRs
#42679 failing with #40855 in web mweb desktop and iOS, comment
#42661 - pending validation in mWeb, iOS, Android and Desktop
#42619 - pending validation in desktop
#42593 pending validation in iOS
#42487 pending validation in mweb and desktop
#42468 pending validation in iOS
#42467 - pending validation in mweb, desktop and android
#42462 - pending validation in iOS
#42461 - pending validation in iOS
#42383 - pending validation in iOS
#42363 - pending validation in iOS
#42360 - pending validation in desktop, android and iOS
#42347 - pending validation in iOS
#42324 - pending validation in iOS
#42315 - pending validation in iOS
#42192 - pending validation in desktop
#42176 - pending validation in iOS

[kavimuru]

Regression 14 steps left in the TR
unchecked PRs
#42679 failing with #40855 in web mweb desktop and iOS - #42679 (comment)
#42467 failing with #42466 bug not fixed in web, desktop, android and iOS
#42467 (comment)
#42176 failing with #42888 and #42890

#42315 - Pending validation in iOS
#42241 -pending validation in android
#42360 - pending validation in mweb

[kavimuru]

Regression is completed.

Unchecked PRs:
#42679 failing with #40855 in web mweb desktop and iOS - #42679 (comment)
#42467 failing with #42466 bug not fixed in web, desktop, android and iOS
#42467 (comment)
#42176 failing with #42888 and #42890
#42315 failing with #42314 bug not fixed in desktop, comment

Open blockers:
#42885
#42910
#42912
#42957

[grgia]

demoted #42910

[roryabraham]

Working on a PR to fix 3 reported regressions and at least two more unreported regressions, including one of the last two deploy blockers. @hoangzinh is helping test that PR presently: https://expensify.slack.com/archives/C02NK2DQWUX/p1717457491171329

Going to shift gears into investigating the last unresolved blocker.

[mountiny]

checking #42467 off as it does not have to hold the deploy

[mountiny]

checking #42315 off as the raised problem seems to be pusher-related
checking #42679 off as the fix is waiting for onyx bump to come back in
checking #42914 off as it was reverted

[mountiny]

Graphs are looking good. This is a fresh crash but that should be fixed with #42734

[mountiny]