[$250] Taxes - Edited tax is not grayed out in Tax list in submit manual flow

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go offline.
4. Go to Categories > Edit a category name.
5. Go to Tags > Edit a tag name.
6. Go to Taxes > Edit a tax name and rate.
7. Go to workspace chat.
8. Go to + > Submit expense > Manual.
9. Proceed to confirmation page.
10. Look for the edited items in Category, Tag and Tax list.

Expected Result:

All the edited items in Category, Tag and Tax list will be grayed out.

Actual Result:

The edited items in Category and Tag list are grayed outm but the edited item in Tax list is not grayed out.
in production : None of the items are grayed out

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6497254_1717148135452.20240531_172958.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0132c9043b25b1d684
• Upwork Job ID: 1796662203817881600
• Last Price Increase: 2024-05-31

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #vip-vsb

[MonilBhavsar]

Commented on the offending PR #42620 (comment)
Let's handle this as a regression

[MonilBhavsar]

Not worth blocking deploy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0132c9043b25b1d684

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[iwiznia]

@Krishna2323 introduced this here #41066

[iwiznia]

Actually reverted it here #42953

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[vishnu-karuppusamy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edited Tax rate items in the workspace are not grayed out in offline mode.

What is the root cause of that problem?

The graying out is based on the property pendingAction which is missing in the tax rates data.

What changes do you think we should make in order to solve the problem?

Add the pendingAction property to the updatePolicyTaxValue, renamePolicyTax and other setters of the tax rate data.

                  taxRates: {
                      taxes: {
                          [taxID]: {
                              value: stringTaxValue,
                              pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                              pendingFields: {value: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE},
                              errorFields: {value: null},
                          },
                      },
                  }

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

📣 @vishnu-karuppusamy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vishnu-karuppusamy]

Contributor details
Your Expensify account email: vishnu566662@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01fded0233eaf38db6

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[vishnu-karuppusamy]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

Updated the email in the last reply.

[vishnu-karuppusamy]

Please share if there's any update on the proposal.

[ishpaul777]

PR fixing this is on Prod. No payment due here, this has been handled by origing PR author and reviewer.

[sonialiap]

Closing issue since no payment is needed