Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - Tags - 3-dot menu in tag RHP animation stutters #42908

Closed
1 of 6 tasks
izarutskaya opened this issue May 31, 2024 · 12 comments
Closed
1 of 6 tasks

[$250] Web - Tags - 3-dot menu in tag RHP animation stutters #42908

izarutskaya opened this issue May 31, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented May 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.78-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings.
  3. Go to Tags.
  4. Click on any tag.
  5. Click 3-dot menu.

Expected Result:

3-dot menu will animate smoothly (production behavior).

Actual Result:

3-dot menu animation slightly stutters. It seems to animate The menu seems to appear in two sizes when animating - small size first then regular size.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6497080_1717138358021.20240531_144610.mp4
Bug6497080_1717138403645!Screenshot_2024-05-31_at_14 53 04

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0124d96a65b48fcae1
  • Upwork Job ID: 1796501094393847808
  • Last Price Increase: 2024-05-31
Issue OwnerCurrent Issue Owner: @ikevin127
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@Beamanator Beamanator added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels May 31, 2024
@melvin-bot melvin-bot bot changed the title Web - Tags - 3-dot menu in tag RHP animation stutters [$250] Web - Tags - 3-dot menu in tag RHP animation stutters May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0124d96a65b48fcae1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@Beamanator
Copy link
Contributor

I don't think this is a big enough problem to be a blocker so demoted it

@ikevin127
Copy link
Contributor

Coming from #42911, looks like the offending PR was identified as #36292, hence both issues have the same root cause and the solution from there should fix this issue as well since the issue comes from the same component.

Therefore I'd suggest having this put on Hold for #42911.

Copy link

melvin-bot bot commented Jun 6, 2024

@Beamanator, @kevinksullivan, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2024
@ikevin127
Copy link
Contributor

The issue is not reproducible anymore since it was fixed in #42911 by PR #43013, therefore I suggest closing as fixed.
cc @Beamanator @kevinksullivan

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2024
@Beamanator
Copy link
Contributor

Thanks so much for keeping track of that, I agree let's close this out 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants