[HOLD for payment 2024-06-11] [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default

[lakchote]

We need to remove Taxes from the LHN when we're disconnecting from Xero and we had taxes sync enabled.

[mountiny]

@trjExpensify based on the comment this was not fully fixed, I think we need to find someone to look into this / retest and fix if its not done yet #42467 (comment)

[trjExpensify]

Cool, I can retest after the next deploy.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave Collect] [Xero] Disable taxes if previously enabled when connecting to QBO #42467

If no regressions arise, payment will be issued on 2024-06-11. 🎊

[trjExpensify]

Can't repro this. Asking for a retest.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@lakchote Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@lakchote 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

Still waiting for a retest. CC: @mvtglobally @m-natarajan

[melvin-bot]

@lakchote 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@lakchote 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

This issue has not been updated in over 14 days. @lakchote eroding to Weekly issue.

[lakchote]

@mvtglobally @m-natarajan can you please retest as per @trjExpensify's comment above ?

[kbecciv]

By following steps from #42466 (comment) - Taxes are enabled when connecting to QBO

2024-07-01.21-09-49.mp4

[lakchote]

#42466 (comment)

I found the culprit, and pushed a PR to fix it here

cc @trjExpensify once you'll see why we weren't seeing the bug... ah 😄

[trjExpensify]

Dang, nice sleuthing!

[mvtglobally]

Issue is reproducible during KI retests.

[lakchote]

Fix disconnect QBO on native devices #44952

PR to fix this is up for review.

[allroundexperts]

Comment for assignment

[bondydaa]

assigned @allroundexperts since they're helping to test the PR #44952

[trjExpensify]

The regression period is over on this. Confirming payment summary as follows:

• $250 to @allroundexperts for the C+ review

Go ahead and request! Closing.

[JmillsExpensify]

$250 approved for @allroundexperts