Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Log out - URL in sign in page is ../settings/troubleshoot after logging out #43057

Closed
3 of 6 tasks
m-natarajan opened this issue Jun 4, 2024 · 29 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Troubleshoot.
  3. Log out.
  4. Note that URL in sign in page.

Expected Result:

URL in sign in page should be staging.new.expensify.com

Actual Result:

URL in sign in page is https://staging.new.expensify.com/settings/troubleshoot
after logging out.
The URL could be report URL other than https://staging.new.expensify.com/settings/troubleshoot
after logging out.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6501931_1717526574343.bandicam_2024-06-05_02-40-43-249.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100e267e9dc04f517
  • Upwork Job ID: 1798115131297120256
  • Last Price Increase: 2024-06-04
  • Automatic offers:
    • getusha | Reviewer | 102613522
    • dominictb | Contributor | 102613525
Issue OwnerCurrent Issue Owner: @getusha
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@tgolen tgolen added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels Jun 4, 2024
@melvin-bot melvin-bot bot changed the title Log out - URL in sign in page is ../settings/troubleshoot after logging out [$250] Log out - URL in sign in page is ../settings/troubleshoot after logging out Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0100e267e9dc04f517

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@tgolen
Copy link
Contributor

tgolen commented Jun 4, 2024

I am removing the deploy blocker label since this is an edge case flow. I'm also marking it as external to have it investigated further.

@anmurali anmurali added Daily KSv2 and removed Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 4, 2024
@gorvk
Copy link

gorvk commented Jun 5, 2024

Hi, I would like to work on this issue.
I found the root cause and I think It is related to navigation after user sign out from InitialSettingsPage

Copy link

melvin-bot bot commented Jun 5, 2024

📣 @gorvk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@bernhardoj
Copy link
Contributor

Reverting #42465 solves the issue for me.

@gorvk
Copy link

gorvk commented Jun 5, 2024

📣 @gorvk! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Expensify account email: dev.gouravk@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01c682f3611e8d2f4d

@gorvk
Copy link

gorvk commented Jun 5, 2024

Reverting #42465 solves the issue for me.

@bernhardoj on reverting, will it not reopen the app crashing issue related #42465 PR ?

@dominictb
Copy link
Contributor

Can u guys reproduce this on latest main? I couldn't reproduce it.

@gorvk
Copy link

gorvk commented Jun 5, 2024

Can u guys reproduce this on latest main? I couldn't reproduce it.

I was also confused at first, and after debugging it is reproducible on staging.new.expensify.com

@dominictb
Copy link
Contributor

@bernhardoj would u please provide video evidence before and after reverting #42465?

@bernhardoj
Copy link
Contributor

The video is not exactly the same as in OP as it would be long to log out and log in twice, but you can see the URL path stays but is fixed after removing the patched code.

Screen.Recording.2024-06-05.at.18.26.54.mov

@ishpaul777
Copy link
Contributor

i am able to reproduce and reverting #42465 solves this, i think we need to modify regex to keep the trailing single / so @react-navigation logic can work properly.

updated Regex- path.replace(/(\/{2,})/g, '/')

Screen.Recording.2024-06-05.at.4.19.36.PM.mov

@getusha
Copy link
Contributor

getusha commented Jun 5, 2024

Since the offending PR is still in the regression period @dominictb and @ishpaul777 handle this.

@dominictb
Copy link
Contributor

alright, I'll wait for assignment before raising the PR cc @ishpaul777

@ishpaul777
Copy link
Contributor

@dominictb just to confirm are you able to reproduce and will you use this solution #43057 (comment)?

@dominictb
Copy link
Contributor

@ishpaul777 yes 👍

@ishpaul777
Copy link
Contributor

🎀 👀 🎀

Copy link

melvin-bot bot commented Jun 5, 2024

Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Jun 5, 2024

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 6, 2024
@getusha
Copy link
Contributor

getusha commented Jun 18, 2024

Handled by @ishpaul777 and @dominictb as a regression

@getusha getusha removed their assignment Jun 18, 2024
@ishpaul777
Copy link
Contributor

we are good to close this one! No payment requires

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

This issue has not been updated in over 15 days. @tgolen, @anmurali, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@tgolen tgolen closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants