-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-24] [$125] [Search v1] Search page: Show dates for prior year transactions #43209
Comments
Triggered auto assignment to @greg-schroeder ( |
P.S. We're going to need web and mobile mocks from the design team. I reached out to them. |
@Expensify/design would love your ideas on how to display this |
Job added to Upwork: https://www.upwork.com/jobs/~017440ce6c14aca464 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
Upwork job price has been updated to $125 |
Looks dope! I'll go ahead and take this so we can open up to community. cc @luacmartins |
Ah...haha you beat me to it. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Search page: Show dates for prior year transactions What is the root cause of that problem?New change. What changes do you think we should make in order to solve the problem?Change column width to w96 at this place:
Change the date format at this place:
|
I agree we should just keep it simple and make the column wider. |
Let's go with @ShridharGoel's solution. In the meantime, can you confirm what the width should be? Is w96 good? @dannymcclain @shawnborton 🎀👀🎀 C+ reviewed |
Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@ShridharGoel why use 96 for the column width? In the mockup we're using 80. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-28. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
IMO, It would be fair to increase the bounty 125 - 250 as usual since there're many code changes and discussions cc @luacmartins @ShridharGoel |
This was a simple change, so I think the current bounty of $125 is applicable here. |
Not overdue, we're holding for payment |
PR was deployed to prod on the 17th, so the payment due date is actually the 24th. cc @greg-schroeder |
@shawnborton, @luacmartins, @greg-schroeder, @ShridharGoel, @mountiny, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Oh. Okay. I'll process this now then |
@ShridharGoel please accept the offer in Upwork so I can pay you, thanks! |
bump @ShridharGoel |
Bump @ShridharGoel - moving this to |
Accepted, thanks. |
@greg-schroeder seems like the offer was accepted. Can we close this now? |
Yes it does appear it was finally accepted! I'll close it after I confirm payment! |
Paid |
Problem
We're on the cusp of launching a v1
Search
page, which means it's possible to see transactions from prior years. What I mean by this is that we are now in 2024, and I have a transaction I can find on theSearch
from back in 2017. The issue is that I have no idea looking at the transaction that it's from that far back.Here's the New Expensify transaction.
Here's the Expensify Classic transaction
Solution
When looking at a prior year transaction, show the year, in addition to the month and date.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @greg-schroederThe text was updated successfully, but these errors were encountered: