[$250] [HOLD for payment 2024-07-10] [Search v1] Description doesn't show if merchant is always empty

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Track an expense and enter a description
2. Verify that the description doesn't show and we instead show an empty Merchant column

Expected Result:

Description should show

Actual Result:

Empty merchant column shows

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018090f57984a646e4
• Upwork Job ID: 1811525031241934419
• Last Price Increase: 2024-07-11

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

@luacmartins, it looks like you are working on the PR, and @dukenv0307 is reviewing it. Let me know if we need any other updates here. Thanks!

[Julesssss]

Hi, we had a bug raised here that I believe is an edge case when no merchant information is available. I don't think it should be a blocker, but please could you confirm that the expected behaviour is for ordering by description to be desired behaviour (and should be fixed). Thanks!

[alexpensify]

Waiting for this one to go to production

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix should show merchant #44181

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[alexpensify]

@dukenv0307—To prepare for the payment date, I think this notice is wrong: #44180 (comment). Please let me know if I need to send the offer via Upwork. Thanks!

[alexpensify]

Payouts due:

• Contributor: N/A - Internal
• Contributor+: $250 @dukenv0307

Upwork job is https://www.upwork.com/jobs/~018090f57984a646e4

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018090f57984a646e4

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[alexpensify]

I figured out that I need to complete the payment process in Upwork. I sent over an offer in Upwork. @dukenv0307, please accept and I can complete the payment process. Thanks!

https://www.upwork.com/jobs/~018090f57984a646e4

[dukenv0307]

@alexpensify I accepted it thank you!

[melvin-bot]

@alexpensify, @luacmartins, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Closing - I've completed the payment process in Upwork. All set here.