[Payment due 7-25] Review duplicate - "resolved the duplicate" system message disappears after restarting app

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (can be manual, scan or distance)
4. Wait for "Review duplicate" button to show up in transaction thread
5. Click Review duplicate
6. Click Keep all
7. Note that "resolved the duplicate" system message shows up
8. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
9. Return to the same transaction thread in Step 7

Expected Result:

"Resolved the duplicate" system message will remain

Actual Result:

"Resolved the duplicate" system message disappears after restarting app/relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6523232_1719250015751.20240625_012220.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[rlinoz]

It looks like we are not sending the action back in the DismissViolation response, so it is not a FE bug, also this is a new feature and I don't think we need to block on this.

@pecanoro do you know if this is being handled somewhere else?

[pecanoro]

Hmm, yeah, I don't think we create any report actions for this in the back-end

[rlinoz]

@pecanoro just to be sure, I was reading the doc and we should right? If so, I think we can do that in this issue.

[rlinoz]

Will check in #wave-collect later.

[pecanoro]

Hmm, the problem is that this action can be taken by many people. So the submitter can dismiss it, but the admin will see it either way. I remember discussing it, but I can't remember what we agreed on.

[rlinoz]

Posted on slack

[rlinoz]

Continuing the conversation on slack.

[rlinoz]

Here is the plan for this one:

• Add an ACTION_UNHOLD here if the accountID dismissing the violation is the submitter and a DISMISSED_VIOLATION if it is the approver
• Start checking the violationName here to decide on what message we send back
• Update the DismissViolation command to accept a list of optimisticReportActionID in Web-E
• Replicate the logic of which type of action to create when creating the optimistic action in the App and start sending an optimisticReportActionID when calling DismissViolation for duplicate transactions

Hopefully I will have some PRs by tomorrow EOD.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Update for Melvin - working on a PR

[Christinadobrzyn]

@allroundexperts should we move this to weekly since the PR is under review?

[allroundexperts]

PR got merged @Christinadobrzyn 😄

[allroundexperts]

See #45315

[Christinadobrzyn]

Awesome! looks like it just went to production so updating the Title for the payment date and switching this to weekly for the time being.

[Christinadobrzyn]

Payday is coming up so going to move this back to daily.

Payouts due:

• Contributor+: $250 @allroundexperts - through NewDot

Do we need a regression test?

[Christinadobrzyn]

nudge @allroundexperts

[allroundexperts]

Regression test

1. Open the app and Go to any workspace chat
2. Submit two same expenses (can be manual, scan or distance)
3. Wait for "Review duplicate" button to show up in transaction thread
4. Click Review duplicate and select Keep all
5. Note that "resolved the duplicate" system message shows up
6. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
7. Return to the same transaction thread in Step 5

Verify that "Resolved the duplicate" system message will remain

Do we 👍 or 👎 ?

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/416107

Closing since @allroundexperts payment will be through NewDot. Payment summary here- #44294 (comment)

[JmillsExpensify]

$250 approved for @allroundexperts