Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details #44462

Closed
6 tasks done
lanitochka17 opened this issue Jun 26, 2024 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4673461
Email or phone of affected tester (no customers): applausetester+062524dr002@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open app or go to staging.new.expensify.com
  2. Log in with any account without a wallet configured
  3. Go to Settings > Wallet
  4. Click on 'Enable wallet'
  5. Follow the bank account flow until the final 'Confirm' page (using Bank: Chase / Account: 1111 / First name: Alberta / Last name: Bobbeth / SSN: 3333)
  6. Tap 'Confirm' button

Expected Result:

Idology questions flow has started

Actual Result:

Nothing happens after pressing the 'Confirm' button. Idology questions flow does not start

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6524686_1719361533938.Desktop-Wallet-No-idology.questions-flow.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014deaa2c3f332d2e4
  • Upwork Job ID: 1806785838003619663
  • Last Price Increase: 2024-06-28
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @OfstadC
Issue OwnerCurrent Issue Owner: @OfstadC
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 26, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@thienlnam @OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@thienlnam
Copy link
Contributor

It seems like this failed because of a non-matching SSN (logs)

I wonder if this was updated for our test bank account recently but it doesn't seem to be from any recent changes

@thienlnam
Copy link
Contributor

Posted here, https://expensify.slack.com/archives/C03SSAQ7P/p1719415968231039 but don't think this is a result of changes made

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 26, 2024
@thienlnam
Copy link
Contributor

Actually, after some confirmation in the thread there's a bug here and it seems to be that the KBA questions do not show up after the initial failure and resubmission

@thienlnam thienlnam added the DeployBlockerCash This issue or pull request should block deployment label Jun 27, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

Current assignee @thienlnam is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam thienlnam removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 27, 2024
@thienlnam thienlnam changed the title Wallet - Idology questions flow does not start after entering bank account details [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details Jun 27, 2024
@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014deaa2c3f332d2e4

@melvin-bot melvin-bot bot changed the title [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details Jun 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Current assignee @Pujan92 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 28, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Jul 2, 2024

@Pujan92 Any update here?

@OfstadC
Copy link
Contributor

OfstadC commented Jul 9, 2024

@Pujan92 Please provide an update by EOD. Thanks!

@Pujan92
Copy link
Contributor

Pujan92 commented Jul 9, 2024

Sorry @OfstadC, The PR merged and the code in the production on 5th July. I think bcoz of Hold the automation isn't worked for this issue.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details [HOLD for payment 2024-07-17] [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details Jul 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @Pujan92 does not require payment (Contractor)
  • @koko57 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
  • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Pujan92] Determine if we should create a regression test for this bug.
  • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@OfstadC
Copy link
Contributor

OfstadC commented Jul 10, 2024

Thanks @Pujan92 ! Could you complete the BZ checklist when you have a chance? Thanks! 😃

@Pujan92
Copy link
Contributor

Pujan92 commented Jul 10, 2024

@OfstadC I believe that will be handled in the parent issue #36648

@OfstadC
Copy link
Contributor

OfstadC commented Jul 11, 2024

Ah okay! 😅 Thanks @Pujan92 !

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @Pujan92 does not require payment (Contractor)
  • @koko57 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
  • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Pujan92] Determine if we should create a regression test for this bug.
  • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Jul 17, 2024

Closing this out -

No payment needed per:

For reference, here are some details about the assignees on this issue:

@Pujan92 does not require payment (Contractor)
@koko57 does not require payment (Contractor)

And checklist should be covered here

@OfstadC OfstadC closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants