-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/44462 show idology questions #44628
Fix/44462 show idology questions #44628
Conversation
Re-assigning to @Pujan92 since he reviewed the other PRs related to the refactor |
Reviewer Checklist
Screenshots/VideosiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-01.at.11.34.51.mp4iOS: mWeb Safarisimulatora.mp4MacOS: Chrome / SafariScreen.Recording.2024-07-01.at.10.02.56.movMacOS: Desktop |
ios/Podfile.lock
Outdated
@@ -2552,7 +2558,7 @@ SPEC CHECKSUMS: | |||
react-native-airship: 38e2596999242b68c933959d6145512e77937ac0 | |||
react-native-blob-util: 1ddace5234c62e3e6e4e154d305ad07ef686599b | |||
react-native-cameraroll: f373bebbe9f6b7c3fd2a6f97c5171cda574cf957 | |||
react-native-config: 5330c8258265c1e5fdb8c009d2cabd6badd96727 | |||
react-native-config: 5ce986133b07fc258828b20b9506de0e683efc1c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert all podfile changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pujan92 done!
@thienlnam We are receiving the Screen.Recording.2024-07-01.at.11.55.03.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
@Pujan92 you need to select the first option for every question to pass. Any other combination of answers will fail KYC. |
Thanks @MariaHCD, I just tested and able to pass with the first option. Screen.Recording.2024-07-01.at.15.37.45.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM and testing the case when the correct answers are provided correctly moved forward to the Onfido step:
Screen.Recording.2024-07-01.at.2.15.52.PM.mov
Would be good to get @shawnborton's review of the design for the KBA questions: |
The design of the questions looks good to me! cc @Expensify/design too for visibility. |
@thienlnam @MariaHCD @Pujan92 are we good to merge this? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @thienlnam did you want to give this a final review?
Ah, @thienlnam is OOO till July 8th. Merging! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.4-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fixed Issues
$ #44462
PROPOSAL: -
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-28.at.17.59.15.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-06-28.at.16.58.17.mp4
MacOS: Desktop