[WAITING ON DOMINICTB][HOLD for payment 2024-08-01] [$250] Report field - List field shows "dropdown" as selected when different initial value is default

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4695978
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses.
4. Go to workspace settings > Report fields.
5. Click Add field.
6. Create a List type report field, add a few list values and select an initial value (important).
7. Go to workspace chat.

Expected Result:

The List type report field will have the initial list value in Step 6 as selected.

Actual Result:

The List type report field shows "dropdown" as the initial list value.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533100_1720103746001.20240704_223441.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162c3c8677de552d3
• Upwork Job ID: 1808914763702199073
• Last Price Increase: 2024-07-04
• Automatic offers:
• shubham1206agra | Contributor | 102994079

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave-collect - Release 1

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The List type report field shows "dropdown" as the initial list value.

What is the root cause of that problem?

we already have the logic to merge the reportField from policy and report in

App/src/libs/ReportUtils.ts

Line 2580 in f73cdc4

const mergedFieldIds = Array.from(new Set([...policyReportFields.map(({fieldID}) => fieldID), ...reportFields.map(({fieldID}) => fieldID)]));

But we're not setting the optimistic data for report.fieldList in

App/src/libs/actions/Policy/ReportFields.ts

Line 154 in f73cdc4

optimisticData: [

so the reportFiled in this case will be the reportField from policy

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 68 in f73cdc4

const fieldValue = isTitleField ? report.reportName : reportField.value ?? reportField.defaultValue;

and it has value: dropdown

What changes do you think we should make in order to solve the problem?

We can get the report by policyID and expense type.

then set the optimistic data for reportField of report same as what BE return (without value key)

We can check the bug for other field type (text, date) as well.

What alternative solutions did you explore? (Optional)

We can remove the value: dropdown in reportField of policy optimistically

Result

[dominictb]

Updated proposal to add the result

[tgolen]

@dominictb can you please create a PR for this? Were you able to identify if this is a regression, and if so, from which PR?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162c3c8677de552d3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[luacmartins]

Report fields are under a beta and this doesn't really break anything, so removing the deployer label.

[rushatgabhane]

Approved, pending internal review and merge

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: optimistically add report field for all expense reports #44894

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @dominictb requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

@dominictb what's your Upworks profile? Could you also add your Upworks name to your GH profile please?

Alternatively, you can apply here: https://www.upwork.com/jobs/~0162c3c8677de552d3

[jliexpensify]

Payment Summary

• C: @dominictb $250

Upworks job

[shubham1206agra]

@rushatgabhane will be given payment at the end of project.

[jliexpensify]

Cheers, fixed!

[jliexpensify]

bump @dominictb what's your Upworks profile? Could you also add your Upworks name to your GH profile please?

Alternatively, you can apply here: https://www.upwork.com/jobs/~0162c3c8677de552d3

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1808914763702199073/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

Bump @dominictb to provide me with your upworks profile

Bump @rushatgabhane for checklist

[rushatgabhane]

@jliexpensify regression steps to add -

1. Go to workspace settings > Report fields.
2. Click Add field.
3. Create a List type report field, add a few list values and select an initial value (important).
4. Go to workspace chat.
5. Submit two expenses.
6. Verify that: The List type report field will have the initial list value as selected

[rushatgabhane]

no separate payment required for report fields

[dominictb]

@jliexpensify Sorry for the delay, here's my Upwork profile https://www.upwork.com/freelancers/~01f70bed1934fd35d5

[jliexpensify]

Thanks @dominictb , invited you.

[dominictb]

@jliexpensify I accepted it thanks 🙏

[jliexpensify]

Paid, and job closed.