[HOLD for payment 2024-09-17][$250] [Tracking][Search v2.1] Follow up issues

[luacmartins]

A couple of clean up items as we start to roll out Search v2:

• Remove getQueryHash
• Add better error handling to SaerchUtils.buildJSONQuery
• Add comments to getFilters
• Add policyID to grammar
• Send index from the backend to simplify frontend sorting logic.
• Group multi-select filters as an array

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833881850571575893
• Upwork Job ID: 1833881850571575893
• Last Price Increase: 2024-09-11

[luacmartins]

Gonna get to this soon

[luacmartins]

We'll handle these once the filter PRs are done.

[Kicu]

I will start to work on adding policyIDs to grammar.
This task is a bit tricky since we have a lot of special hacks for making policyIDs query param work with existing .../w/<policyid>/report... routes and with workspace switcher.

Once we move policyIDs into AST we need to go over all the special edge cases and refactor or remove them

[luacmartins]

Thanks for picking this one up!

[289Adam289]

I can start to work on updating the grammar to return multi-select values in the same AST node.

[289Adam289]

While working on issues related to grammar i came across two bugs:

1. Operators >= and <= don't work. It is directly connected to how peggy handles disjunctions and should be easily solved by changing the order of operators in grammar.

2. Words in free text that have a prefix equal to any keyword results in unexpected behavior. For example ink results in {operator: 'eq', left: 'in', right: 'k'}. It is caused by operator in filter being optional.

I can implement fixes in the pr updating the grammar

[luacmartins]

Ah nice catch @289Adam289, yea let's update those cases

[Kicu]

I wanted to suggest that we mark:
Add better error handling to SaerchUtils.buildJSONQuery as done.

Reason: the error that is thrown now is a bit more verboes (done by me) and @289Adam289 has updated the grammar and gave better names to parts of grammar.
https://github.com/Expensify/App/blob/main/src/libs/SearchUtils.ts#L324

Here's how an error looks now:

[luacmartins]

@Kicu agreed! I marked it as resolved in the OP.

[melvin-bot]

Current assignee @lschurr is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833881850571575893

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[luacmartins]

Last PR was deployed to prod yesterday

[Kicu]

Alright, lets close it. For now sorting seems to work, so perhaps better not to update something that is working alright.

[lschurr]

Could you clarify what you're referring to @Kicu? The PR was deployed and now we wait 7 days before closing to make sure there are no regressions.

[luacmartins]

@lschurr @Kicu was replying to my comment here

[rayane-djouah]

@lschurr Friendly reminder, the payment is due today

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rayane-djouah paid $250 via Upwork

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1833881850571575893/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[lschurr]

Looks like the automation didn't work, so I manually sent the offer @rayane-djouah - https://www.upwork.com/nx/wm/offer/104006695

[rayane-djouah]

@lschurr - Accepted the offer. Thanks!