[HOLD for payment 2024-08-26] [Upgrades] [$250] Workspace - Incorrect app navigation after clicking on back button on upgrade RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to More features.
3. Scroll down.
4. Toggle on Report fields.
5. Click on the back button on RHP.
6. Note that the page scrolls up.
7. Enable Accounting.
8. Go to Accounting.
9. Toggle on NetSuite.
10. Click on the back button on RHP.
11. Note that app returns to workspace profile page.

Expected Result:

In Step 6, page will not scroll up after clicking on back button on RHP
In Step 11, app will remain on the same accounting page after clicking on back button on RHP

Actual Result:

In Step 6, page scrolls up after clicking on back button on RHP
In Step 11, app remains on the same accounting page after clicking on back button on RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop #45930

Screenshots/Videos

Add any screenshot/video evidence

Bug6546241_1721312718504.20240718_222222.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d4828d1746446dd
• Upwork Job ID: 1813956464241732548
• Last Price Increase: 2024-07-18

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d4828d1746446dd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[roryabraham]

not 100% sure this needs to block deploy. It's definitely not a back-end issue though

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect app navigation after clicking on back button on upgrade RHP

What is the root cause of that problem?

Don't pass backTo param when navigating to UpgradePage

App/src/components/ConnectToNetSuiteButton/index.tsx

Line 59 in 6fe216e

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));

What changes do you think we should make in order to solve the problem?

App/src/components/ConnectToNetSuiteButton/index.tsx

Line 59 in 6fe216e

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));

App/src/components/ConnectToSageIntacctButton/index.tsx

Line 66 in 6fe216e

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.intacct.alias));

Add backTo props Navigation.getActiveRouteWithoutParams() as third prams:

For example:

 Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias, Navigation.getActiveRouteWithoutParams());

What alternative solutions did you explore? (Optional)

[lanitochka17]

The same issue is observed when performing other steps:

1. Create a workspace
2. Navigate to workspace settings page
3. Click on More features > toggle Report fields
4. Click on 'Upgrade' > click on 'Got it, thank'

Bug6546300_1721315740557.Screen_Recording_2024-07-18_at_6.08.30_in_the_evening.mp4

[trjExpensify]

@allroundexperts @garrettmknight @rushatgabhane pretty sure GK just created an issue for this: #45692

[garrettmknight]

Yeah, this is a dupe and also not a blocker. Closing in favor of the other one.

[cretadn22]

@garrettmknight This isn't dupe. Could you please check the description?

[cretadn22]

Go to staging.new.expensify.com
Go to More features.
Scroll down.
Toggle on Report fields.
Click on the back button on RHP.
Note that the page scrolls up.
Enable Accounting.
Go to Accounting.
Toggle on NetSuite.
Click on the back button on RHP.
Note that app returns to workspace profile page.

[garrettmknight]

Sorry @cretadn22 - I think I closed the wrong issue. Reopening here, but @allroundexperts might already be fixing this one in a separate PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: redirect to proper place after upgrade #45730

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Also taking this one off the payment hold while we wait for the updated PR to ship.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[garrettmknight]

Going to keep this one open to confirm payment with @rushatgabhane for his review. Slack convo here.

[garrettmknight]

Closing - still waiting on @rushatgabhane to request payment though.

[JmillsExpensify]

Payment summary:

• Reviewer: @rushatgabhane $250

[garrettmknight]

$250 approved for @rushatgabhane