Tax - App returns to More features after upgrading workspace to Control plan from Tax code

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a Collect workspace.
3. Go to workspace settings > More features.
4. Enable Taxes.
5. Go to Taxes.
6. Click on any tax rate.
7. Click Tax code.
8. Click Upgrade.

Expected Result:

App will open tax code editor after upgrading the workspace to Control plan.

Actual Result:

App returns to More features after upgrading the workspace to Control plan from Tax code page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571836_1723626082443.20240814_165854.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think this issue might be related to the #wave-control

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax - App returns to More features after upgrading workspace to Control plan from Tax code

What is the root cause of that problem?

backTo param is not passed to ROUTES.WORKSPACE_UPGRADE.getRoute.

App/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx

Lines 147 to 152 in 29fb6bb

	if (!PolicyUtils.isControlPolicy(policy)) {
	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.taxCodes.alias));
	return;
	}
	Navigation.navigate(ROUTES.WORKSPACE_TAX_CODE.getRoute(`${policyID}`, taxID));
	}}

What changes do you think we should make in order to solve the problem?

Pass backTo param as ROUTES.WORKSPACE_TAX_CODE.getRoute(${policyID}, taxID).

What alternative solutions did you explore? (Optional)

[rlinoz]

Yeah, I think it is related to this PR #46617

The fix is the same thing we are doing for tags.

[rlinoz]

CP fixed the issue

[rlinoz]

We can close this one.