[HOLD for payment 2024-08-07] [$250] Taxes - App blinks after saving tax code

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is under Control plan

1. Go to staging.new.expensify.com
2. Go to Control workspace settings
3. Go to Taxes
4. Click on any tax
5. Click Tax code
6. Edit the tax code
7. Save it

Expected Result:

App will not blink after saving tax code

Actual Result:

App blinks after saving tax code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546244_1721313034292.20240718_222903.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c99af8616c4c904d
• Upwork Job ID: 1813973597069496991
• Last Price Increase: 2024-07-18
• Automatic offers:
• dominictb | Contributor | 103179553

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[carlosmiceli]

The blinking doesn't happen only when you edit a tax code, but also when you click on a tax to edit it. However, it's such an imperceptible/small issue that I wouldn't call this a blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c99af8616c4c904d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App blinks after saving tax code

What is the root cause of that problem?

We use dismiss modal here to clear the page with outdated tax code before navigating here

However dismissModal is not suitable for this purpose because it will clear the modal entirely and when navigating it creates a new modal. The ideal UX here is to clear the page with outdated tax code only and retain the modal, when we navigate we use that same modal.

What changes do you think we should make in order to solve the problem?

Replace

App/src/pages/workspace/taxes/WorkspaceTaxCodePage.tsx

Line 44 in 6e7852d

Navigation.dismissModal();

by

Navigation.goBack();

[Small cleanup] While investigating I found that the variable canEditTaxCode here was named incorrectly, because the user can edit tax code only if it's control policy.

So it can be updated to be equal to PolicyUtils.isControlPolicy(policy) and then we negate the condition here

What alternative solutions did you explore? (Optional)

NA

[fedirjh]

@dominictb Thanks for the proposal. proposal looks good to me and works as expected.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignees @puneetlath and @carlosmiceli are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[puneetlath]

@carlosmiceli I'll let you take CME on this one.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: app blinks after saving tax code #45749

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@dominictb has been paid.

@fedirjh bump on the checklist for you.

[fedirjh]

BugZero Checklist:

• Link to the PR: [GL] Tax - Add tax code #43156
• Link to comment: [GL] Tax - Add tax code #43156 (comment)
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: We can update this regression test: fix: Hm it's not here shown when edit the tax code and save #45983 (comment)

Regression Test Proposal

Precondition: Workspace is under Control plan

1. Go to staging.new.expensify.com
2. Go to Control workspace settings
3. Go to Taxes
4. Click on any tax
5. Click Tax code
6. Edit the tax code and Save it
7. Verify that: Tax code is saved and App will not blink after saving tax code 

• Do we agree 👍 or 👎

[puneetlath]

Payment summary:

• C - $250 - @dominictb - paid via Upwork
• C+ - 250 - @fedirjh - to be paid via NewDot

Thanks everyone!

[garrettmknight]

$250 approved for @fedirjh