[HOLD for payment 2024-08-05] Improve filtering performance in task share page

[roryabraham]

This issue is branched off of #37619 and was created specifically to manage the lifecycle and payments of this PR: #40290

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[roryabraham]

@TMisiukiewicz please comment for assignment and link #40290 to this issue before opening it up for review. Thanks

[TMisiukiewicz]

Thank you @roryabraham, linked the issue and opened a PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• perf: Implement filtering in Task - Share Somewhere #40290

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @TMisiukiewicz does not require payment (Contractor)
• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @TMisiukiewicz is from an agency-contributor and not due payment
• ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

This is part of another PR

• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal

• Open Create Menu
• Press "Assign task"
• Fill the name and go to the next step
• Press "Share somewhere"
• Type something that matches any of the options existing on your list
• Verify option is displayed after finished typing
• Verify the list has the same options in the same order as the same search text applied on main branch
• Clear the input and type one of the restricted emails (For example admin@expensify.com)
• Verify "No results found" message is displayed

Do we agree 👍 or 👎

[zanyrenney]

Looks good, thanks @ZhenjaHorbach

[zanyrenney]

there seems to be no existing upwork job, reapplying the label to retrigger

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

[zanyrenney]

@ZhenjaHorbach invited you to the upwork job, please accept for payout.

[zanyrenney]

https://www.upwork.com/jobs/~017f8379bba041b305

[ZhenjaHorbach]

@ZhenjaHorbach invited you to the upwork job, please accept for payout.

Done, Thank you !

[zanyrenney]

hired! accept for payout please @ZhenjaHorbach

[ZhenjaHorbach]

hired! accept for payout please @ZhenjaHorbach

Done !

[zanyrenney]

Payment Summary

Upwork Job

• Contributor: @TMisiukiewicz is from an agency-contributor and not due payment
• ROLE: @ZhenjaHorbach paid $250 via Upwork (LINK)