[HOLD for payment 2024-07-24][$250] Improve filtering performance in new chat page

[roryabraham]

Coming from #37619

This issue is specifically for the new chat page and the C+ payment for this PR

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01941ca75bd8c92948
• Upwork Job ID: 1806743203181122627
• Last Price Increase: 2024-06-28
• Automatic offers:
• alitoshmatov | Contributor | 103149732

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01941ca75bd8c92948

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[roryabraham]

@TMisiukiewicz has already opened the PR, and @hungvu193 is our C+. no additional help needed here

[TMisiukiewicz]

Hi, can I get assigned to this issue please?

Is it possible to make this issue more generic so I can link the rest of the remaining issues, or create a separate ones for each one of them? Not sure what approach is preferred on your side.
#40764
#40338
#40290
#40285

[hungvu193]

Not overdue, reviewing PR

[stephanieelliott]

Assigned you, @TMisiukiewicz! Sure, I suppose we can make the issue more generic -- any suggestions on how we can generalize this? Happy to make those changes

[TMisiukiewicz]

@stephanieelliott I think "Improve filtering performance in remaining search pages" would be good. The list of the pages affected with this change:

• Invite to the room page
• Assign to task page
• Share somewhere page
• Share logs page

[melvin-bot]

@TMisiukiewicz, @hungvu193, @stephanieelliott, @roryabraham Huh... This is 4 days overdue. Who can take care of this?

[hungvu193]

PR is under review

[alitoshmatov]

Coming from here, where I reviewed this PR #40793. If this is corresponding issue, can I get assigned to this? or is there separate issue

[stephanieelliott]

Hey @roryabraham wanted to check with you since you manually created this issue. Does this sound ok to you, to expand the scope of the issue to cover all remaining search pages? Here is what is being suggested:

I think "Improve filtering performance in remaining search pages" would be good. The list of the pages affected with this change:

Invite to the room page
Assign to task page
Share somewhere page
Share logs page

[melvin-bot]

@TMisiukiewicz @hungvu193 @stephanieelliott @roryabraham this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Pujan92]

Coming from here, where I reviewed this PR #40793. If this is corresponding issue, can I get assigned to this? or is there separate issue

+1, I have reviewed this PR. @roryabraham @stephanieelliott Could you plz help us with the payment?

[melvin-bot]

@TMisiukiewicz, @hungvu193, @stephanieelliott, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hm, ok -- so @Pujan92 and @alitoshmatov are also C+ here in addition to @hungvu193? I'll assume that is correct and update the assignment

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[TMisiukiewicz]

@stephanieelliott from discussion above I feel like it's easier to have separate issues for each PR, could you please create them for:

• Invite to chatroom page
• Task - Share somewhere
• Task - Assign

That's the only thing stopping me from undrafting those PRs 🙏

[roryabraham]

Hey, looks like we should create 1 issue per PR to help clarify and streamline the payments here:

• [HOLD for payment 2024-07-24][$250] Improve filtering performance in workspace invite page #46145 for PR perf: Intive to workspace options filtering #40793 cc @alitoshmatov
• Improve filtering performance in Request Money and Send Money #46147 for PR perf: Filter options in Request Money and Send Money #40235 cc @Pujan92
• [HOLD for payment 2024-07-30] Improve filtering performance in share logs page #46148 for PR perf: filter Share Logs options #40285 cc @mollfpr
• [HOLD for payment 2024-08-05] Improve filtering performance in room invite page #46149 for PR perf: Room Invite options filtering #40764
• [$250] [HOLD for payment 2024-08-05] Improve filtering performance in task assignee list #46150 for PR perf: Implement filtering in task assignee list #40338
• [HOLD for payment 2024-08-05] Improve filtering performance in task share page #46151 for PR perf: Implement filtering in Task - Share Somewhere #40290

That means we'll handle only PR #40350 in this issue.

[roryabraham]

sorry for the confusion everyone, hopefully things should be smoother sailing for this larger "improve filtering performance" initiative going forward and everyone should get paid.

@stephanieelliott, please issue payment of $250 to @hungvu193 for his review of #40350, then close this out. Thanks!

[stephanieelliott]

Cool, thanks for clarifying @roryabraham! #40350 was deployed to prod on 7/16 so I will go ahead and pay this now.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @TMisiukiewicz - no payment due (expert contrib)
• Contributor+: @hungvu193 - $250, please request via ND

Upwork job is here: https://www.upwork.com/jobs/~01941ca75bd8c92948

[hungvu193]

Requested on ND

[JmillsExpensify]

$250 approved for @hungvu193