[$250] [HOLD for payment 2024-08-05] Improve filtering performance in task assignee list

[roryabraham]

This issue is branched off of #37619 and was created specifically to manage the lifecycle and payments of this PR: #40338

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141f3da35d3e190a5
• Upwork Job ID: 1820580872082146605
• Last Price Increase: 2024-08-05

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[roryabraham]

@TMisiukiewicz please comment for assignment and link #40338 to this issue before opening it up for review. Thanks

[TMisiukiewicz]

Thank you @roryabraham, linked the issue and opened the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• perf: Implement filtering in task assignee list #40338

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @TMisiukiewicz does not require payment (Contractor)
• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@brunovjk] The PR that introduced the bug has been identified. Link to the PR:
• [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@brunovjk] Determine if we should create a regression test for this bug.
• [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[brunovjk]

• [@brunovjk] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@brunovjk] Determine if we should create a regression test for this bug. Yes
• [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal:

1. Open global create and select "Assign task"
2. Name the task
3. Press "Assignee"
4. Type a value that matches some of the options from the list
5. Verify a list loaded and it has the same order and content filtered appropriately
6. Clear input and type non-existing e-mail
7. Verify non-existing email appears if it's valid
8. Clear input and type one of the restricted emails e.g. admin@expensify.com
9. Verify "No results found" appears

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @TMisiukiewicz is from an agency-contributor and not due payment
• ROLE: @brunovjk paid $250 via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141f3da35d3e190a5

[melvin-bot]

Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@brunovjk - I sent an offer in Upwork. Please accept and I can complete the required process:

#46150 (comment)

Thanks!

[brunovjk]

Done! Thank you @alexpensify :D

[alexpensify]

Closing - I completed the payment process in Upwork. I'll revisit this GH for the regression test process.