Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-18] [$125] Bank account - Company website field is blank on confirmation page if it is not modified #48674

Closed
6 tasks done
IuliiaHerets opened this issue Sep 6, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.30-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Account is a private domain account (Expensifail).
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows
  3. Click Connect bank account > Connect manually
  4. Proceed to Step 4 - Enter Company's Tax ID page
  5. Enter Tax ID > Next
  6. Note that the website field is auto populated with https://www.applause.expensifail.com/
  7. Click Next without changing the website field.
  8. Proceed to confirmation page for Company info.
  9. Click Confirm.

Expected Result:

In Step 8, Company website field should be filled with the auto-populated website in Step 6.

Actual Result:

In Step 8, Company website field is not filled with the auto-populated website in Step 6.
In Step 9, after clicking Confirm, it shows the error "Please provide a valid Website" when the field is auto-populated with a valid website.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6594679_1725574349282.bank.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831968301055311769
  • Upwork Job ID: 1831968301055311769
  • Last Price Increase: 2024-09-09
Issue OwnerCurrent Issue Owner: @greg-schroeder
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 6, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@madmax330
Copy link
Contributor

Looks like we're not rendering the default value. I think this is a front-end issue

@madmax330 madmax330 added the External Added to denote the issue can be worked on by a contributor label Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021831968301055311769

@melvin-bot melvin-bot bot changed the title Bank account - Company website field is blank on confirmation page if it is not modified [$250] Bank account - Company website field is blank on confirmation page if it is not modified Sep 6, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@mkzie2
Copy link
Contributor

mkzie2 commented Sep 6, 2024

Edited by proposal-police: This proposal was edited at 2024-09-06 08:48:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, Company website field is not filled with the auto-populated website in Step 6.
In Step 9, after clicking Confirm, it shows the error "Please provide a valid Website" when the field is auto-populated with a valid website.

What is the root cause of that problem?

Input's default value is not saved into draft unless user changes value.

We only save draft in onInputChange:

if (inputProps.shouldSaveDraft && !formID.includes('Draft')) {
FormActions.setDraftValues(formID, {[inputKey]: value});
}

What changes do you think we should make in order to solve the problem?

We should save draft whenever we use the default values:

} else if (inputProps.shouldUseDefaultValue && inputProps.defaultValue !== undefined && inputValues[inputID] === undefined) {
// We force the form to set the input value from the defaultValue props if there is a saved valid value
inputValues[inputID] = inputProps.defaultValue;
} else if (inputValues[inputID] === undefined) {
// We want to initialize the input value if it's undefined
inputValues[inputID] = inputProps.defaultValue ?? getInitialValueByType(inputProps.valueType);
}

We can write a dedicated function to save draft with the following logic since we use it many times:

if (inputProps.shouldSaveDraft && !formID.includes('Draft')) {
FormActions.setDraftValues(formID, {[inputKey]: value});
}

@bernhardoj
Copy link
Contributor

This happens after we re-enable the auto-populate default website here which was previously temporarily disabled. I think I missed the logic to save it to the draft, I'll recheck it later.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Sep 6, 2024
@mountiny mountiny changed the title [$250] Bank account - Company website field is blank on confirmation page if it is not modified [$125] Bank account - Company website field is blank on confirmation page if it is not modified Sep 9, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 9, 2024
@mountiny
Copy link
Contributor

mountiny commented Sep 9, 2024

@bernhardoj is the PR author with the fix @brunovjk is not online so @hungvu193 will handle the PR review

Copy link

melvin-bot bot commented Sep 9, 2024

Upwork job price has been updated to $125

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Sep 9, 2024
@mountiny mountiny self-assigned this Sep 9, 2024
@mountiny
Copy link
Contributor

mountiny commented Sep 9, 2024

$125 payment to @hungvu193 only

@brunovjk
Copy link
Contributor

brunovjk commented Sep 9, 2024

@bernhardoj is the PR author with the fix @brunovjk is not online so @hungvu193 will handle the PR review

I didn't notice any ping/tag about this before. Thanks for handling it @mountiny.

@greg-schroeder
Copy link
Contributor

greg-schroeder commented Sep 17, 2024

All right - well once this is finished up, the payment summary is simply:

C+: @hungvu193 - $250 - you can make a manual request in ND

@hungvu193
Copy link
Contributor

Requested on ND

@mountiny mountiny added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Weekly KSv2 labels Sep 17, 2024
@mountiny mountiny changed the title [$125] Bank account - Company website field is blank on confirmation page if it is not modified [HOLD for payment 2024-09-18] [$125] Bank account - Company website field is blank on confirmation page if it is not modified Sep 17, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 17, 2024
@greg-schroeder
Copy link
Contributor

All right then, closing as the payment summary is there and the request was made - payment approver can take a look here tomorrow 9/18 to confirm!

@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
Status: Done
Development

No branches or pull requests

9 participants