-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-09-16] Categories - Unable to select subcategory as the default spend category #48690
Comments
Triggered auto assignment to @twisterdotcom ( |
Triggered auto assignment to @lakchote ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Don't need another recording to show this one. Very obvious.
@lakchote is this an easy fix? Can we make it external? |
I can't find an offending PR here tbh. |
The offending PR is #48391 (cc @BartoszGrajdek @marcaaron) It adds the category spend selector, without it Settings are empty which means the offending code is in the PR: |
CP requested here |
QA tests passed since CP (link). Removing the deploy blocker label. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Can we close this now @lakchote? |
Yes, closing! |
Hey can we please reopen to process payment here for #48708, cc @lakchote @twisterdotcom |
Ah, okay. When did it hit prod? |
Deployed 9 sept. with this checklist #48664, should be ready for payment |
Payment Summary:
|
Accepted Thanks! |
@twisterdotcom Could you please release payment https://www.upwork.com/nx/wm/workroom/38389275/overview |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Subcategory can be selected as the default spend category.
Actual Result:
Subcategory cannot be selected as the default spend category. It reverts to the previous category after selecting the subcategory.
RBR is shown next to the workspace but there is no error message after selecting the subcategory as the default category.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6595057_1725606854193.20240906_151151.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: