[HOLD for payment - waiting on deploy][$250] Category - Default spend categories not displayed when creating workspace offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30.11
Reproducible in staging?: Yes
Reproducible in production?: N/A
Issue was found when executing this PR: #48708
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in
2. Disable internet connection
3. Create a new workspace
4. Open the workspace settings > Categories
5. Select Settings

Expected Result:

The default category selector is displayed

Actual Result:

The default category selector is not displayed when creating a workspace offline

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6595607_1725648023167.Recording__760.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021832156142441767995
• Upwork Job ID: 1832156142441767995
• Last Price Increase: 2024-09-06

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[gijoe0295]

Edited by proposal-police: This proposal was edited at 2023-10-17T00:49:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The default category selector is not displayed when creating a workspace offline

What is the root cause of that problem?

We should the default spend categories description even when there's no such categories because the workspace is created offline and BE does not return that yet.

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Lines 95 to 103 in cfbd0b3

	{!!currentPolicy && listItems && (
	<>
	<View style={[styles.mh5, styles.mt2, styles.mb1]}>
	<Text style={[styles.headerText]}>{translate('workspace.categories.defaultSpendCategories')}</Text>
	<Text style={[styles.mt1, styles.lh20]}>{translate('workspace.categories.spendCategoriesDescription')}</Text>
	</View>
	<ScrollView>{listItems}</ScrollView>
	</>
	)}

Note that listItems here is an array initialized to [] so even when there's no mccGroup data, we would still have an empty array:

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Line 42 in cfbd0b3

let data: ListItem[] = [];

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Line 57 in cfbd0b3

return data.map((item) => (

What changes do you think we should make in order to solve the problem?

Modify the above condition to check length of listItems.

!!currentPolicy && listItems.length > 0

[Nodebrute]

@BartoszGrajdek from this pr #48708

[ishpaul777]

I think @BartoszGrajdek is not around i'll take care of this as C+ on offending PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021832156142441767995

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[ishpaul777]

Draft PR is here #48747

[ishpaul777]

@marcochavezf Opened for review 🙏

[marcochavezf]

Thanks @gijoe0295 @ishpaul777 for the quick solution!

[mountiny]

CP ing the PR

[johncschuster]

Payment Summary

Contributor: @ishpaul777 owed $250 via Upwork

[ishpaul777]

Hey i am not due payment here this came from a PR i reviewed

[johncschuster]

Thanks for letting me know, @ishpaul777!