[$100] Attachment - Chat blinks when txt attachment is uploaded

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47778
Issue reported by: Applause Internal Team

Action Performed:

1. Log in with a Gmail account
2. Open any 1:1 chat
3. Send a txt attachment

Expected Result:

It shouldn't blink.

Actual Result:

Chat blinks when txt attachment is uploaded.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594960_1725596733523.OIMT0425.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833566073242365431
• Upwork Job ID: 1833566073242365431
• Last Price Increase: 2024-09-27
• Automatic offers:
• nkdengineer | Contributor | 104162747

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[isabelastisser]

review by EOD

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833566073242365431

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat blinks when txt attachment is uploaded.

What is the root cause of that problem?

We get the download data via withOnyx. It's an old HOC and can affect some weird lifecycle component bugs. As in this case, BaseAnchorForAttachmentsOnly disappears and appears again after the API is complete.

App/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx

Lines 81 to 84 in 762bffc

	export default withOnyx<BaseAnchorForAttachmentsOnlyProps, BaseAnchorForAttachmentsOnlyOnyxProps>({
	download: {
	key: ({source}) => {
	const sourceID = (source?.match(CONST.REGEX.ATTACHMENT_ID) ?? [])[1];

What changes do you think we should make in order to solve the problem?

We should remove withOnyx in this component and use useOnyx to get the download data

const [download] = useOnyx(`${ONYXKEYS.COLLECTION.DOWNLOAD}${sourceID}`);

App/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx

Lines 81 to 84 in 762bffc

	export default withOnyx<BaseAnchorForAttachmentsOnlyProps, BaseAnchorForAttachmentsOnlyOnyxProps>({
	download: {
	key: ({source}) => {
	const sourceID = (source?.match(CONST.REGEX.ATTACHMENT_ID) ?? [])[1];

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-09-11.at.12.34.21.mov

[isabelastisser]

@getusha, can you please review the proposal above? thanks!

[melvin-bot]

@isabelastisser, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[isabelastisser]

Hey @getusha, any updates?

[getusha]

@nkdengineer what about this line?

App/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx

Line 84 in 0c618ac

const sourceID = (source?.match(CONST.REGEX.ATTACHMENT_ID) ?? [])[1];

seems like we are not directly using the value

[nkdengineer]

@getusha What do you mean? When we remove withOnyx, we also remove this line and we already get the sourceID in the component.

[getusha]

oh yeah you're right

[getusha]

@nkdengineer could you test this on latest main? seems like uploading txt file isn't working on android & ios mweb

[nkdengineer]

@getusha I still able to upload the txt file for Android app and web on the latest main.

Screen.Recording.2024-09-16.at.16.45.31.mov

Screen.Recording.2024-09-16.at.16.44.31.mov

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[isabelastisser]

@getusha, can you please follow up on the comment above and provide an update? Thanks!

[melvin-bot]

@isabelastisser @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[isabelastisser]

Bump @getusha for an update. Thanks!

[getusha]

Reviewing

[getusha]

I was able to reproduce this, i think we should adjust the price of this issue to $100 since withOnyx to useOnyx migration issues are priced that range. @nkdengineer's proposal looks good to me
🎀 👀 🎀 C+ Reviewed.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

@getusha Thanks for your review. Here is my opinion: because this bug isn't a normal migration task, it takes more effort to find the RCA of the issue. Then let us keep the price.

[nkdengineer]

@MonilBhavsar Please look at this comment #48697 (comment) to move forward with this issue, thanks.

[MonilBhavsar]

Let's do it 👍

[melvin-bot]

Upwork job price has been updated to $100

[MonilBhavsar]

I have updated the price cc @isabelastisser

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@isabelastisser, @MonilBhavsar, @getusha, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[nkdengineer]

@getusha this PR is ready for review

[isabelastisser]

@getusha, can you please provide an update? Thanks!

[getusha]

Reviewing the PR, will complete it in short.