Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up - App freezes after logging in with a new Expensifail account #50149

Closed
6 tasks done
IuliiaHerets opened this issue Oct 3, 2024 · 26 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.44-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh011001@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Expensifail account.

Expected Result:

App will not freeze after logging in with a new Expensifail account.

Actual Result:

App freezes after logging in with a new Expensifail account.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6623231_1727962469868.hang.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 3, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 3, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jasperhuangg
Copy link
Contributor

@luacmartins @hannojg Do you think this could be fixed by #50143?

@srikarparsi
Copy link
Contributor

Able to reproduce, trying to see where this came from. Pretty sure this is going to be backend but looking

@srikarparsi
Copy link
Contributor

Do you think this could be fixed by #50143?

Hm, this is only occurring for expensifail accounts, not other accounts. So I don't think it's the search router?

@srikarparsi
Copy link
Contributor

Sometimes logging in just freezes, and other times, logging in returns to the login screen after briefly flashing the inbox screen. In the second case, the OpenApp response is session expired:

image

@jasperhuangg
Copy link
Contributor

@srikarparsi Do you think it has to do with the expensifail domain room being so large?

@srikarparsi
Copy link
Contributor

I'm honestly not sure yet. I just tried reproducing it on dev with the expensifail domain and it's not reproducible (so maybe it is that?):

image

But I'm going to look at code changes that occurred recently in Web E and Auth and see if there's anything that stands out. I also think we can remove the DeployBlockerCash label (because it's not reproducible on dev and there's no mentions of expensifail other than test accounts in App). What do you think?

@srikarparsi
Copy link
Contributor

srikarparsi commented Oct 3, 2024

Do you think it has to do with the expensifail domain room being so large?

I just tested on production and there's weird behavior on there as well. It doesn't freeze like it does on staging but any reports past the LHN screen size doesn't load (so the LHN isn't scrollable) and I also see the #social chat which I regularly don't see in expensifail (but clicking on it removed it from LHN)

EDIT: Actually all of this if fixed with logging out and logging back in.

image

@jasperhuangg
Copy link
Contributor

When you were reproducing here were you just signing in with your existing expensifail account or creating a new one?

@srikarparsi
Copy link
Contributor

When you were reproducing #50149 (comment) were you just signing in with your existing expensifail account or creating a new one?

Existing expensifail account

@srikarparsi
Copy link
Contributor

This comment was fixed by logging out and logging back in. So since it occurs in staging and not prod, I don't think it's something to do with the domain being too big but rather a code regression I believe

@jasperhuangg
Copy link
Contributor

Agree, it feels like if the UI freezes up the problem stems from front-end changes that cause the JS thread to implode when dealing with large amounts of data. Have you tried reproducing with regular accounts? I tried signing in with my regular expensify email on staging and didn't see anything.

@jasperhuangg
Copy link
Contributor

Hmm not able to reproduce with my expensifail account on staging.

@srikarparsi
Copy link
Contributor

Agree, it feels like if the UI freezes up the problem stems from front-end changes that cause the JS thread to implode when dealing with large amounts of data.

Hm, I don't thinkk it's that because of the OpenApp response and this isn't happening for my expensify account on staging - which I believe has more data than my expensifail account

@srikarparsi
Copy link
Contributor

Hmm not able to reproduce with my expensifail account on staging.

Do you think you could try signing out and signing back in?

@jasperhuangg
Copy link
Contributor

I've tried signing out and signing back in 3 times already and haven't been able to reproduce it. Could it be account specific?

I'm starting to feel like if we can't reproduce it consistently on all expensifail accounts it's not worth blocking deploy on, especially because expensifail accounts are all testing accounts.

@jasperhuangg jasperhuangg added Daily KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Oct 3, 2024
@jasperhuangg
Copy link
Contributor

Removing all deploy blocker labels via what I said above.

@srikarparsi
Copy link
Contributor

I've tried signing out and signing back in 3 times already and haven't been able to reproduce it. Could it be account specific?

Very interesting, I'm not able to reproduce this either anymore (Tried twice)

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@srikarparsi
Copy link
Contributor

Removing all deploy blocker labels via what I said above.

Sounds good, thank you for the help!

@jasperhuangg
Copy link
Contributor

Maybe it was the search router? The PR I mentioned above hit Web 17 minutes ago

@srikarparsi
Copy link
Contributor

Yeah could be, I'm still not able to reproduce it.

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@srikarparsi
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@isabelastisser
Copy link
Contributor

Closing this as it can't be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants