Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Option in onboarding guided flow is not based on sign up's choice #50298

Open
1 of 6 tasks
IuliiaHerets opened this issue Oct 6, 2024 · 8 comments
Open
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #47619
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.expensify.com
  2. choose "Organize my own expenses"
  3. Enter a new account
  4. Click on Sign up
  5. Click on join

Expected Result:

Onboarding modal is only limited to "Track and budget expenses", "Get paid back by my employer", "Chat and split bills with friends".

Actual Result:

Onboarding modal contains 'Manage my team's expenses' and 'Something else'.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6625690_1728152152202.video_2024-10-05_02-02-54.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Oct 6, 2024
Copy link

melvin-bot bot commented Oct 6, 2024

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 6, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@carlosmiceli
Copy link
Contributor

I'll take this one since it's onboarding related.

@carlosmiceli carlosmiceli added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Oct 6, 2024
@carlosmiceli
Copy link
Contributor

@IuliiaHerets could you show me the URL where you're being redirected after signing up? That'll help me know if it's a FE or BE issue.

Copy link

melvin-bot bot commented Oct 7, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@ChavdaSachin
Copy link
Contributor

Same RCA as #50299
Proposal here

@carlosmiceli carlosmiceli added the DeployBlocker Indicates it should block deploying the API label Oct 7, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 7, 2024
@carlosmiceli carlosmiceli removed the DeployBlocker Indicates it should block deploying the API label Oct 7, 2024
@carlosmiceli
Copy link
Contributor

This PR will solve the bug once it's CPed: https://github.com/Expensify/Web-Expensify/pull/43835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants