Fix: Continue button does not work in onboarding modal #50348
Closed
+7
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #50299
$ #50298
PROPOSAL: #50299 (comment)
Tests
Same as QA
Offline tests
N/A
QA Steps
Test 1:
Verify that: Continue button works and the onboarding modal navigates to the next page.
Test 2:
Verify that: Onboarding modal is only limited to "Track and budget expenses", "Get paid back by my employer", "Chat and split bills with friends".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-10-08.at.12.30.12.AM.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-10-07.at.11.58.57.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-07.at.11.55.30.PM.mov
MacOS: Desktop