-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App is locked in spanish #6133
Comments
Triggered auto assignment to @johncschuster ( |
Seems related #5286 |
@kevinksullivan, do you have any reproduction steps on how your app changed to Spanish? Did you change your global settings on your phone or attempt to translate some text? The issue @parasharrajat referenced has a video showing the reproduction steps. Can you take a look to see if their steps match your steps? |
I think what happened for @kevinksullivan and I was that we signed into an account that had Spanish as the preferred language, and then we've been stuck in Spanish since 😆 |
Goooot it. I'm not familiar with how someone would sign into an account that has Spanish as the preferred language. Would you be able to provide repro steps? |
The language picker is hidden behind the internationalization beta, so the reproduction steps would be:
|
Triggered auto assignment to @nickmurray47 ( |
I've ported the repro steps above to the OP. @nickmurray47, please let us know if anything's unclear before this is further triaged! |
Got it! Reproduced the same locally. It seems like right now that when we get the user's preferred locale on sign-in in |
@nickmurray47 is the expectation that this is fixed? Or are there any steps to take now that the PR merged? My apps are all still in Spanish. |
Accounts will no longer be locked into a specific language setting, but for accounts currently locked I'll whip up a snippet or something as a way to get unstuck. |
@kevinksullivan Log into expensify.com (not new.e) with the affected account and run The PR fix hasn't been deployed to staging yet, too. |
Got it, yeah I quickly saw the botify close and wanted to clarify. I ran the script in JS but still no luck. Let me know if that is expected and we're just waiting for this to hit prod. |
Yeah, we still need this to hit prod then running the snippet will work. |
Just tested this out and I think the "Spanish Curse" is fixed 🇪🇸 🎉 |
This was deployed to Prod #6177 (comment) so going to close. Also checked that running this snippet |
I'm back! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Using mobile, desktop, or web apps
Expected Result:
My app should be set to english. And if it is set to Spanish, I should be able to change it back via preferences.
Actual Result:
All of my apps are locked in Spanish and I cannot change it back to English.
Platform:
Version Number: v1.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Notes/Photos/Videos:
Reproduction Steps (ported from comment below):
The language picker is hidden behind the internationalization beta, so the reproduction steps would be:
Settings
->Preferences
, and set the preferred language to españolSlack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1634694602133700
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: