Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is locked in spanish #6133

Closed
kevinksullivan opened this issue Oct 29, 2021 · 17 comments
Closed

App is locked in spanish #6133

kevinksullivan opened this issue Oct 29, 2021 · 17 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Oct 29, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Using mobile, desktop, or web apps

Expected Result:

My app should be set to english. And if it is set to Spanish, I should be able to change it back via preferences.

Actual Result:

All of my apps are locked in Spanish and I cannot change it back to English.

Platform:

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Notes/Photos/Videos:

Reproduction Steps (ported from comment below):

The language picker is hidden behind the internationalization beta, so the reproduction steps would be:

  1. Add an account to the internationalization beta
  2. Sign into that account
  3. Go to Settings -> Preferences, and set the preferred language to español
  4. Sign out.
  5. Sign into another account not in the beta.
  6. App is in spanish 💥

image

image

Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1634694602133700

View all open jobs on GitHub

@kevinksullivan kevinksullivan added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 29, 2021
@MelvinBot
Copy link

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 29, 2021
@parasharrajat
Copy link
Member

Seems related #5286

@johncschuster
Copy link
Contributor

@kevinksullivan, do you have any reproduction steps on how your app changed to Spanish? Did you change your global settings on your phone or attempt to translate some text?

The issue @parasharrajat referenced has a video showing the reproduction steps. Can you take a look to see if their steps match your steps?

@roryabraham
Copy link
Contributor

I think what happened for @kevinksullivan and I was that we signed into an account that had Spanish as the preferred language, and then we've been stuck in Spanish since 😆

@johncschuster
Copy link
Contributor

Goooot it. I'm not familiar with how someone would sign into an account that has Spanish as the preferred language. Would you be able to provide repro steps?

@roryabraham
Copy link
Contributor

roryabraham commented Nov 1, 2021

The language picker is hidden behind the internationalization beta, so the reproduction steps would be:

  1. Add an account to the internationalization beta
  2. Sign into that account
  3. Go to Settings -> Preferences, and set the preferred language to español
  4. Sign out.
  5. Sign into another account not in the beta.
  6. App is in spanish 💥

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johncschuster
Copy link
Contributor

I've ported the repro steps above to the OP.

@nickmurray47, please let us know if anything's unclear before this is further triaged!

@nickmurray47
Copy link
Contributor

Got it! Reproduced the same locally. It seems like right now that when we get the user's preferred locale on sign-in in AuthScreens.js that we're not retrieving the correct value. Going to dig a bit deeper and try to get a quick PR up soon.

@nickmurray47 nickmurray47 added the Reviewing Has a PR in review label Nov 2, 2021
@botify botify closed this as completed Nov 5, 2021
@kevinksullivan
Copy link
Contributor Author

@nickmurray47 is the expectation that this is fixed? Or are there any steps to take now that the PR merged? My apps are all still in Spanish.

@nickmurray47
Copy link
Contributor

Accounts will no longer be locked into a specific language setting, but for accounts currently locked I'll whip up a snippet or something as a way to get unstuck.

@nickmurray47
Copy link
Contributor

nickmurray47 commented Nov 8, 2021

@kevinksullivan Log into expensify.com (not new.e) with the affected account and run NVP.set('preferredLocale', 'en'); in the JS console.

The PR fix hasn't been deployed to staging yet, too.

@kevinksullivan kevinksullivan reopened this Nov 8, 2021
@kevinksullivan
Copy link
Contributor Author

The PR fix hasn't been deployed to staging yet, too.

Got it, yeah I quickly saw the botify close and wanted to clarify. I ran the script in JS but still no luck. Let me know if that is expected and we're just waiting for this to hit prod.

@nickmurray47
Copy link
Contributor

Yeah, we still need this to hit prod then running the snippet will work.

@roryabraham
Copy link
Contributor

Just tested this out and I think the "Spanish Curse" is fixed 🇪🇸 🎉

@nickmurray47
Copy link
Contributor

This was deployed to Prod #6177 (comment) so going to close. Also checked that running this snippet NVP.set('preferredLocale', 'en'); in your old.e's console will fix the problem in new.e @kevinksullivan

@kevinksullivan
Copy link
Contributor Author

I'm back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants