Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set locale language from preferences #6177

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Nov 2, 2021

Details

The method setLocale updates the user's locale NVP to a different language. We were calling it when a user logs in from an account with different language settings, which resulted in them unexpectedly having different language settings.

Fixed Issues

$ #6133

Tests / QA Steps

(On an account with internalization beta turned on)

  1. Login to account A, go to Settings > Preferences and set to Espanol.
  2. Logout and login to an account, Account B, with its locale default set to English. (The login page will still be in Spanish since we just set the local language for the app.) Verify that the Settings page is all in English.
  3. Log back into Account A and verify the Settings page is still in Spanish.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-11-02 at 1 29 44 PM
Screen Shot 2021-11-02 at 1 29 10 PM

Mobile Web

Desktop

iOS

Android

@nickmurray47 nickmurray47 self-assigned this Nov 2, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner November 2, 2021 20:17
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team November 2, 2021 20:17
@nickmurray47 nickmurray47 requested review from MonilBhavsar and a team and removed request for Luke9389 November 2, 2021 20:17
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team November 2, 2021 20:18
@nickmurray47
Copy link
Contributor Author

This is ready for review!

@Luke9389
Copy link
Contributor

Luke9389 commented Nov 5, 2021

Considering it's Saturday for Monil, I'm going to merge this. I think it's fine for these PRs to coexist.

@Luke9389 Luke9389 merged commit ead7bef into main Nov 5, 2021
@Luke9389 Luke9389 deleted the nmurray-update-locale branch November 5, 2021 19:14
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants